aboutsummaryrefslogtreecommitdiff
path: root/bfd/opncls.c
diff options
context:
space:
mode:
authorH.J. Lu <hjl.tools@gmail.com>2021-07-02 13:42:32 -0700
committerH.J. Lu <hjl.tools@gmail.com>2021-07-05 08:51:35 -0700
commit918172470430ea6fa082c941e6789add88331197 (patch)
treed32fe8758c189052469f5b029bef5ebc3fc01a51 /bfd/opncls.c
parentc919d6be44913ed52d91c203e87e529ee17de805 (diff)
downloadgdb-918172470430ea6fa082c941e6789add88331197.zip
gdb-918172470430ea6fa082c941e6789add88331197.tar.gz
gdb-918172470430ea6fa082c941e6789add88331197.tar.bz2
ld: Cache and reuse the IR archive file descriptor
Linker plugin_object_p opens the IR archive for each IR archive member. For GCC plugin, plugin_object_p closes the archive file descriptor. But for LLVM plugin, the archive file descriptor remains open. If there are 3000 IR archive members, there are 3000 file descriptors for them. We can run out of file descriptors petty easily. 1. Add archive_plugin_fd and archive_plugin_fd_open_count to bfd so that we can cache and reuse the IR archive file descriptor for all IR archive members in the archive. 2. Add bfd_plugin_close_file_descriptor to properly close the IR archive file descriptor. bfd/ PR ld/28040 * archive.c (_bfd_archive_close_and_cleanup): Close the archive plugin file descriptor if needed. * bfd.c (bfd): Add archive_plugin_fd and archive_plugin_fd_open_count. * opncls.c (_bfd_new_bfd): Initialize to -1. * plugin.c (bfd_plugin_open_input): Cache and reuse the archive plugin file descriptor. (bfd_plugin_close_file_descriptor): New function. (try_claim): Call bfd_plugin_close_file_descriptor. * plugin.h (bfd_plugin_close_file_descriptor): New. * bfd-in2.h: Regenerated. ld/ PR ld/28040 * plugin.c (plugin_input_file): Add ibfd. (release_plugin_file_descriptor): New function. (release_input_file): Call release_plugin_file_descriptor to close input->fd. (plugin_object_p): Call release_plugin_file_descriptor to close input->fd. Also call release_plugin_file_descriptor if not claimed. * testsuite/config/default.exp (RANLIB): New. * testsuite/ld-plugin/lto.exp: Run ranlib test.
Diffstat (limited to 'bfd/opncls.c')
-rw-r--r--bfd/opncls.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/bfd/opncls.c b/bfd/opncls.c
index 74df4c2..4fb7932 100644
--- a/bfd/opncls.c
+++ b/bfd/opncls.c
@@ -89,6 +89,8 @@ _bfd_new_bfd (void)
return NULL;
}
+ nbfd->archive_plugin_fd = -1;
+
return nbfd;
}