aboutsummaryrefslogtreecommitdiff
path: root/bfd/ieee.c
diff options
context:
space:
mode:
authorIan Lance Taylor <ian@airs.com>1993-10-28 20:36:48 +0000
committerIan Lance Taylor <ian@airs.com>1993-10-28 20:36:48 +0000
commit14aa9a78c39300d49cc6a816dbb833a897d9c6e0 (patch)
treebd02850c1278360caf4934bf2ed75918efc4b1bc /bfd/ieee.c
parentd17eb3db0e135a449c94977aabae938e96584603 (diff)
downloadgdb-14aa9a78c39300d49cc6a816dbb833a897d9c6e0.zip
gdb-14aa9a78c39300d49cc6a816dbb833a897d9c6e0.tar.gz
gdb-14aa9a78c39300d49cc6a816dbb833a897d9c6e0.tar.bz2
gcc -Wall lint:
* coff-h8300.c (h8300_reloc16_estimate): Declare return type. Remove useless statement probably left by code copy. * cpu-i960.c (compatible): Fully bracket matrix initializer. * elf32-hppa.c (hppa_elf_build_arg_reloc_stub): Use bfd_xmalloc rather than xmalloc. Use realloc and check the return value rather than xrealloc. (hppa_elf_get_section_contents): Add some casts. * elf32-i386.c (elf_i386_reloc_type_lookup): Remove unused variable. Add default case to switch. * hp300hpux.c: Declare aout_32_write_syms. * i386bsd.c, i386linux.c, netbsd386.c (N_SHARED_LIB): Define as 0 (definition from aout/aout64.h is always 0 anyhow). * i386lynx.c (swap_std_reloc_in): Remove unused variable. * ieee.c (ieee_write_id): length can never be negative. (read_id): Likewise. (ieee_archive_p): Remove unused variable. * libcoff-in.h (bfd_perform_slip): Declare. * libcoff.h: Rebuilt. * oasys.c (oasys_write_sections): Remove zero initialization of static structure. * reloc16.c: Indentation change.
Diffstat (limited to 'bfd/ieee.c')
-rw-r--r--bfd/ieee.c30
1 files changed, 15 insertions, 15 deletions
diff --git a/bfd/ieee.c b/bfd/ieee.c
index 3018996..da2193a 100644
--- a/bfd/ieee.c
+++ b/bfd/ieee.c
@@ -116,7 +116,7 @@ DEFUN(ieee_write_id,(abfd, id),
CONST char *id)
{
size_t length = strlen(id);
- if (length >= 0 && length <= 127) {
+ if (length <= 127) {
ieee_write_byte(abfd, (bfd_byte)length);
}
else if (length < 255) {
@@ -173,7 +173,7 @@ DEFUN(read_id,(ieee),
size_t length;
char *string;
length = this_byte_and_next(ieee);
- if (length >= 0x00 && length <= 0x7f) {
+ if (length <= 0x7f) {
/* Simple string of length 0 to 127 */
}
else if (length == 0xde) {
@@ -360,27 +360,27 @@ typedef struct
static
reloc_howto_type abs32_howto
- = HOWTO(1,0,2,32,false,0,false,true,0,"abs32",true,0xffffffff, 0xffffffff,false);
+ = HOWTO(1,0,2,32,false,0,complain_overflow_bitfield,0,"abs32",true,0xffffffff, 0xffffffff,false);
static
reloc_howto_type abs16_howto
- = HOWTO(1,0,1,16,false,0,false,true,0,"abs16",true,0x0000ffff, 0x0000ffff,false);
+ = HOWTO(1,0,1,16,false,0,complain_overflow_bitfield,0,"abs16",true,0x0000ffff, 0x0000ffff,false);
static
reloc_howto_type abs8_howto
- = HOWTO(1,0,0,8,false,0,false,true,0,"abs8",true,0x000000ff, 0x000000ff,false);
+ = HOWTO(1,0,0,8,false,0,complain_overflow_bitfield,0,"abs8",true,0x000000ff, 0x000000ff,false);
static
reloc_howto_type rel32_howto
- = HOWTO(1,0,2,32,true,0,false,true,0,"rel32",true,0xffffffff,
+ = HOWTO(1,0,2,32,true,0,complain_overflow_signed,0,"rel32",true,0xffffffff,
0xffffffff,false);
static
reloc_howto_type rel16_howto
- = HOWTO(1,0,1,16,true,0,false,true,0,"rel16",true,0x0000ffff, 0x0000ffff,false);
+ = HOWTO(1,0,1,16,true,0,complain_overflow_signed,0,"rel16",true,0x0000ffff, 0x0000ffff,false);
static
reloc_howto_type rel8_howto
- = HOWTO(1,0,0,8,true,0,false,true,0,"rel8",true,0x000000ff, 0x000000ff,false);
+ = HOWTO(1,0,0,8,true,0,complain_overflow_signed,0,"rel8",true,0x000000ff, 0x000000ff,false);
static ieee_symbol_index_type NOSYMBOL = { 0, 0};
@@ -1055,7 +1055,7 @@ DEFUN(ieee_archive_p,(abfd),
ieee_ar_obstack_type t;
int rec =read_2bytes(&(ieee->h));
if (rec ==(int)ieee_assign_value_to_variable_enum) {
- int record_number = must_parse_int(&(ieee->h));
+ must_parse_int(&(ieee->h));
t.file_offset = must_parse_int(&(ieee->h));
t.abfd = (bfd *)NULL;
ieee->element_count++;
@@ -3001,12 +3001,12 @@ bfd_target ieee_vec =
' ', /* ar_pad_char */
16, /* ar_max_namelen */
1, /* minimum alignment */
-_do_getb64, _do_getb_signed_64, _do_putb64,
- _do_getb32, _do_getb_signed_32, _do_putb32,
- _do_getb16, _do_getb_signed_16, _do_putb16, /* data */
-_do_getb64, _do_getb_signed_64, _do_putb64,
- _do_getb32, _do_getb_signed_32, _do_putb32,
- _do_getb16, _do_getb_signed_16, _do_putb16, /* hdrs */
+bfd_getb64, bfd_getb_signed_64, bfd_putb64,
+ bfd_getb32, bfd_getb_signed_32, bfd_putb32,
+ bfd_getb16, bfd_getb_signed_16, bfd_putb16, /* data */
+bfd_getb64, bfd_getb_signed_64, bfd_putb64,
+ bfd_getb32, bfd_getb_signed_32, bfd_putb32,
+ bfd_getb16, bfd_getb_signed_16, bfd_putb16, /* hdrs */
{ _bfd_dummy_target,
ieee_object_p, /* bfd_check_format */