aboutsummaryrefslogtreecommitdiff
path: root/bfd/elf32-arm.c
diff options
context:
space:
mode:
authorSzabolcs Nagy <szabolcs.nagy@arm.com>2019-10-03 19:11:50 +0100
committerSzabolcs Nagy <szabolcs.nagy@arm.com>2019-10-04 10:54:16 +0100
commitb627f56244cb2930c5891cfde03586987d46b5d2 (patch)
treebcf98c81badd1d49b135cd58671732a9589a8b9a /bfd/elf32-arm.c
parent77c2dba3e843694fae090e237ccdf1b8f65b94e6 (diff)
downloadgdb-b627f56244cb2930c5891cfde03586987d46b5d2.zip
gdb-b627f56244cb2930c5891cfde03586987d46b5d2.tar.gz
gdb-b627f56244cb2930c5891cfde03586987d46b5d2.tar.bz2
[PR ld/25062] arm: sign extend the addend of R_ARM_TLS_GOTDESC
On 64-bit host the 32-bit addend was loaded without sign extension into an unsigned long. bfd/ChangeLog: PR ld/25062 * elf32-arm.c (elf32_arm_final_link_relocate): Sign extend data. ld/ChangeLog: PR ld/25062 * testsuite/ld-arm/arm-elf.exp: Update. * testsuite/ld-arm/tls-gdesc-neg.d: New test. * testsuite/ld-arm/tls-gdesc-neg.s: New test.
Diffstat (limited to 'bfd/elf32-arm.c')
-rw-r--r--bfd/elf32-arm.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/bfd/elf32-arm.c b/bfd/elf32-arm.c
index bb53e03..d52c046 100644
--- a/bfd/elf32-arm.c
+++ b/bfd/elf32-arm.c
@@ -12027,9 +12027,9 @@ elf32_arm_final_link_relocate (reloc_howto_type * howto,
unsigned long data, insn;
unsigned thumb;
- data = bfd_get_32 (input_bfd, hit_data);
+ data = bfd_get_signed_32 (input_bfd, hit_data);
thumb = data & 1;
- data &= ~1u;
+ data &= ~1ul;
if (thumb)
{