aboutsummaryrefslogtreecommitdiff
path: root/bfd/coff-bfd.c
diff options
context:
space:
mode:
authorAlan Modra <amodra@gmail.com>2023-03-25 21:15:46 +1030
committerAlan Modra <amodra@gmail.com>2023-03-27 21:58:46 +1030
commita2c7ca15a5609ea230771fc418511a3b8db16bd1 (patch)
tree3e5b9c33b8f90ce7b8afd8621ca7cdf5ea35caff /bfd/coff-bfd.c
parent3bb1480e2a85de6850863d245e7b6da03a3887f7 (diff)
downloadgdb-a2c7ca15a5609ea230771fc418511a3b8db16bd1.zip
gdb-a2c7ca15a5609ea230771fc418511a3b8db16bd1.tar.gz
gdb-a2c7ca15a5609ea230771fc418511a3b8db16bd1.tar.bz2
Use stdint types in coff internal_auxent
long is a poor choice of type to store 32-bit values read from objects files by H_GET_32. H_GET_32 doesn't sign extend so tests like that in gdb/coffread.c for "negative" values won't work if long is larger than 32 bits. If long is 32-bit then code needs to be careful to not accidentally index negative array elements. (I'd rather see a segfault on an unmapped 4G array index than silently reading bogus data.) long is also a poor choice for x_sect.s_scnlen, which might have 64-bit values. It's better to use unsigned exact width types to avoid surprises. I decided to change the field names too, which makes most of this patch simply renaming. Besides that there are a few places where casts are no longer needed, and where printf format strings or tests need adjusting. include/ * coff/internal.h (union internal_auxent): Use unsigned stdint types. Rename l fields to u32 and u64 as appropriate. bfd/ * coff-bfd.c, * coff-rs6000.c, * coff64-rs6000.c, * coffcode.h, * coffgen.c, * cofflink.c, * coffswap.h, * peXXigen.c, * xcofflink.c: Adjust to suit internal_auxent changes. binutils/ * rdcoff.c: Adjust to suit internal_auxent changes. gas/ * config/obj-coff.h, * config/tc-ppc.c: Adjust to suit internal_auxent changes. gdb/ * coffread.c, * xcoffread.c: Adjust to suit internal_auxent changes. ld/ * pe-dll.c: Adjust to suit internal_auxent changes.
Diffstat (limited to 'bfd/coff-bfd.c')
-rw-r--r--bfd/coff-bfd.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/bfd/coff-bfd.c b/bfd/coff-bfd.c
index 9660b6b..292778e 100644
--- a/bfd/coff-bfd.c
+++ b/bfd/coff-bfd.c
@@ -83,7 +83,7 @@ bfd_coff_get_auxent (bfd *abfd,
if (ent->fix_tag)
{
- pauxent->x_sym.x_tagndx.l =
+ pauxent->x_sym.x_tagndx.u32 =
((combined_entry_type *) pauxent->x_sym.x_tagndx.p
- obj_raw_syments (abfd));
ent->fix_tag = 0;
@@ -91,7 +91,7 @@ bfd_coff_get_auxent (bfd *abfd,
if (ent->fix_end)
{
- pauxent->x_sym.x_fcnary.x_fcn.x_endndx.l =
+ pauxent->x_sym.x_fcnary.x_fcn.x_endndx.u32 =
((combined_entry_type *) pauxent->x_sym.x_fcnary.x_fcn.x_endndx.p
- obj_raw_syments (abfd));
ent->fix_end = 0;
@@ -99,7 +99,7 @@ bfd_coff_get_auxent (bfd *abfd,
if (ent->fix_scnlen)
{
- pauxent->x_csect.x_scnlen.l =
+ pauxent->x_csect.x_scnlen.u64 =
((combined_entry_type *) pauxent->x_csect.x_scnlen.p
- obj_raw_syments (abfd));
ent->fix_scnlen = 0;