aboutsummaryrefslogtreecommitdiff
path: root/bfd/archive.c
diff options
context:
space:
mode:
authorPedro Alves <palves@redhat.com>2017-10-04 14:20:51 +0100
committerAlan Modra <amodra@gmail.com>2017-10-05 12:03:47 +1030
commit2ca7de3746be7484aa5affceafa1ad2e1d789381 (patch)
tree3b828944d881259232614619db2108122a203880 /bfd/archive.c
parent7d36e2799141d206651410c68080f40b88809a3b (diff)
downloadgdb-2ca7de3746be7484aa5affceafa1ad2e1d789381.zip
gdb-2ca7de3746be7484aa5affceafa1ad2e1d789381.tar.gz
gdb-2ca7de3746be7484aa5affceafa1ad2e1d789381.tar.bz2
bfd_set_input_error
A downside to the 2017-10-04 PR22245 fix is that bfd_set_error can now silently accept invalid errors if/when someone passes the a value of the wrong enumeration type, which previously would be caught by the -Wenum-conversion warning. PR 22245 * bfd.c (bfd_set_error): Revert 2017-10-04 change. Remove ellipsis parameter. Split out bfd_error_on_input code to.. (bfd_set_input_error): .. New function. * archive.c (_bfd_write_archive_contents): Use bfd_set_input_error. * vms-lib.c (_bfd_vms_lib_write_archive_contents): Likewise. * bfd-in2.h: Regenerate.
Diffstat (limited to 'bfd/archive.c')
-rw-r--r--bfd/archive.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/bfd/archive.c b/bfd/archive.c
index 3ce3f9e..1e87685 100644
--- a/bfd/archive.c
+++ b/bfd/archive.c
@@ -2309,7 +2309,7 @@ _bfd_write_archive_contents (bfd *arch)
return TRUE;
input_err:
- bfd_set_error (bfd_error_on_input, current, bfd_get_error ());
+ bfd_set_input_error (current, bfd_get_error ());
return FALSE;
}