diff options
author | Tom Tromey <tom@tromey.com> | 2020-11-21 08:49:10 -0700 |
---|---|---|
committer | Tom Tromey <tom@tromey.com> | 2020-12-21 12:55:53 -0700 |
commit | 6c078f0bfe67dd59427986eda110444bbaf29f1f (patch) | |
tree | ac5a72e6f382b8a63eff327bd3779d7ccdc5b837 | |
parent | e1ff6226d8e36896edbdd651753a3e1292381ba0 (diff) | |
download | gdb-6c078f0bfe67dd59427986eda110444bbaf29f1f.zip gdb-6c078f0bfe67dd59427986eda110444bbaf29f1f.tar.gz gdb-6c078f0bfe67dd59427986eda110444bbaf29f1f.tar.bz2 |
Move enum noside earlier in expression.h
For the expression rewrite series, I needed to move enum noside
earlier in expression.h. Because this is a pure move, and because it
seems harmless and uncontroversial to move an enum definition earlier
in a file, I'm pushing it in early, to reduce the size of that series.
Tested by rebuilding.
gdb/ChangeLog
2020-12-21 Tom Tromey <tom@tromey.com>
* expression.h (enum noside): Move earlier.
-rw-r--r-- | gdb/ChangeLog | 4 | ||||
-rw-r--r-- | gdb/expression.h | 44 |
2 files changed, 26 insertions, 22 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog index a3aabb5..142278a 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,7 @@ +2020-12-21 Tom Tromey <tom@tromey.com> + + * expression.h (enum noside): Move earlier. + 2020-12-21 Peter Waller <p@pwaller.net> * interps.c (interpreter_exec_cmd): Restore streams pointers. diff --git a/gdb/expression.h b/gdb/expression.h index c07111c..f30c793 100644 --- a/gdb/expression.h +++ b/gdb/expression.h @@ -67,6 +67,28 @@ enum exp_opcode : uint8_t OP_UNUSED_LAST }; +/* Values of NOSIDE argument to eval_subexp. */ + +enum noside + { + EVAL_NORMAL, + EVAL_SKIP, /* Only effect is to increment pos. + Return type information where + possible. */ + EVAL_AVOID_SIDE_EFFECTS /* Don't modify any variables or + call any functions. The value + returned will have the correct + type, and will have an + approximately correct lvalue + type (inaccuracy: anything that is + listed as being in a register in + the function in which it was + declared will be lval_register). + Ideally this would not even read + target memory, but currently it + does in many situations. */ + }; + union exp_element { enum exp_opcode opcode; @@ -135,28 +157,6 @@ extern expression_up parse_exp_1 (const char **, CORE_ADDR pc, /* From eval.c */ -/* Values of NOSIDE argument to eval_subexp. */ - -enum noside - { - EVAL_NORMAL, - EVAL_SKIP, /* Only effect is to increment pos. - Return type information where - possible. */ - EVAL_AVOID_SIDE_EFFECTS /* Don't modify any variables or - call any functions. The value - returned will have the correct - type, and will have an - approximately correct lvalue - type (inaccuracy: anything that is - listed as being in a register in - the function in which it was - declared will be lval_register). - Ideally this would not even read - target memory, but currently it - does in many situations. */ - }; - extern struct value *evaluate_subexp_standard (struct type *, struct expression *, int *, enum noside); |