diff options
| author | Pedro Alves <pedro@palves.net> | 2022-05-27 16:28:29 +0100 |
|---|---|---|
| committer | Pedro Alves <pedro@palves.net> | 2022-06-17 09:58:49 +0100 |
| commit | 238dc9af03392ecd8129ee54a340efd736782cf9 (patch) | |
| tree | e5ba1fcefc30c036392eeb554a299c39c8344a72 | |
| parent | 5c1ddcb69a01c3d4985ecffbbab126a4e8cd4e33 (diff) | |
| download | gdb-238dc9af03392ecd8129ee54a340efd736782cf9.zip gdb-238dc9af03392ecd8129ee54a340efd736782cf9.tar.gz gdb-238dc9af03392ecd8129ee54a340efd736782cf9.tar.bz2 | |
Convert location_spec_empty_p to a method
This converts location_spec_empty_p to a method of location_spec,
simplifying users, as they no longer have to use
std::unique_ptr::get().
Change-Id: I83381a729896f12e1c5a1b4d6d4c2eb1eb6582ff
| -rw-r--r-- | gdb/breakpoint.c | 3 | ||||
| -rw-r--r-- | gdb/location.c | 10 | ||||
| -rw-r--r-- | gdb/location.h | 4 |
3 files changed, 2 insertions, 15 deletions
diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c index 7e008ba..bfa9e68 100644 --- a/gdb/breakpoint.c +++ b/gdb/breakpoint.c @@ -3699,8 +3699,7 @@ create_exception_master_breakpoint (void) static int breakpoint_location_spec_empty_p (const struct breakpoint *b) { - return (b->locspec != nullptr - && location_spec_empty_p (b->locspec.get ())); + return (b->locspec != nullptr && b->locspec->empty_p ()); } void diff --git a/gdb/location.c b/gdb/location.c index 19b58ab..ae056f3 100644 --- a/gdb/location.c +++ b/gdb/location.c @@ -855,7 +855,7 @@ string_to_location_spec (const char **stringp, /* If the user really specified a location spec, then we're done. */ - if (!location_spec_empty_p (locspec.get ())) + if (!locspec->empty_p ()) return locspec; /* Otherwise, the user _only_ specified optional flags like @@ -876,14 +876,6 @@ string_to_location_spec (const char **stringp, /* See description in location.h. */ -int -location_spec_empty_p (const location_spec *locspec) -{ - return locspec->empty_p (); -} - -/* See description in location.h. */ - void set_location_spec_string (struct location_spec *locspec, std::string &&string) diff --git a/gdb/location.h b/gdb/location.h index 8275fa9..f3b6332 100644 --- a/gdb/location.h +++ b/gdb/location.h @@ -363,10 +363,6 @@ extern location_spec_up const struct language_defn *language, explicit_completion_info *completion_info); -/* A convenience function for testing for unset location specs. */ - -extern int location_spec_empty_p (const location_spec *locspec); - /* Set the location specs's string representation. */ extern void set_location_spec_string (struct location_spec *locspec, |