aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNick Alcock <nick.alcock@oracle.com>2024-07-30 12:28:04 +0100
committerNick Alcock <nick.alcock@oracle.com>2024-07-30 12:28:04 +0100
commit0689d330b27f1921afb10ff4b716b69fdaa7a567 (patch)
tree5eec4611d30809c06ee21d3fee6cf122cee28e48
parentd56f5df657d41303b46f20fa80eae7ad3921b289 (diff)
downloadgdb-users/nalcock/try-enum-reloosening.zip
gdb-users/nalcock/try-enum-reloosening.tar.gz
gdb-users/nalcock/try-enum-reloosening.tar.bz2
libctf: fix ctf_archive_count return value on big-endianusers/nalcock/try-enum-reloosening
This failed to properly byteswap its return value. The ctf_archive format predates the idea of "just write natively and flip on open", and byteswaps all over the place. It's too easy to forget one. The next revision of the archive format (not versioned, so we just tweak the magic number instead) should be native-endianned like the dicts inside it are. libctf/ * ctf-archive.c (ctf_archive_count): Byteswap return value.
-rw-r--r--libctf/ctf-archive.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/libctf/ctf-archive.c b/libctf/ctf-archive.c
index 0034bf0..b73999c 100644
--- a/libctf/ctf-archive.c
+++ b/libctf/ctf-archive.c
@@ -785,7 +785,7 @@ ctf_archive_count (const ctf_archive_t *wrapper)
if (!wrapper->ctfi_is_archive)
return 1;
- return wrapper->ctfi_archive->ctfa_ndicts;
+ return le64toh (wrapper->ctfi_archive->ctfa_ndicts);
}
/* Look up a symbol in an archive by name or index (if the name is set, a lookup