diff options
| author | Tom de Vries <tdevries@suse.de> | 2024-04-24 15:36:02 +0200 |
|---|---|---|
| committer | Tom de Vries <tdevries@suse.de> | 2024-04-24 15:36:02 +0200 |
| commit | a47141329c8e984de61ba3c2f2394bcf4328ee92 (patch) | |
| tree | 7f723e838caa6bbe9f872c5a34dfe98cbb3c4481 | |
| parent | e6a0a281a0bf93bd22247bcd1d68b303dc657845 (diff) | |
| download | gdb-a47141329c8e984de61ba3c2f2394bcf4328ee92.zip gdb-a47141329c8e984de61ba3c2f2394bcf4328ee92.tar.gz gdb-a47141329c8e984de61ba3c2f2394bcf4328ee92.tar.bz2 | |
[gdb/testsuite] Fix gdb.threads/threadcrash.exp for remote host
With test-case gdb.threads/threadcrash.exp using host board local-remote-host
and target board remote-gdbserver-on-localhost I run into:
...
(gdb) PASS: gdb.threads/threadcrash.exp: test_gcore: continue to crash
gcore $outputs/gdb.threads/threadcrash/threadcrash.gcore^M
Failed to open '$outputs/gdb.threads/threadcrash/threadcrash.gcore' for output.^M
(gdb) FAIL: gdb.threads/threadcrash.exp: test_gcore: saving gcore
UNSUPPORTED: gdb.threads/threadcrash.exp: test_gcore: couldn't generate gcore file
...
The problem is that the gcore command tries to save a file on a remote host,
but the filename is a location on build.
Fix this by using host_standard_output_file.
Tested on x86_64-linux.
| -rw-r--r-- | gdb/testsuite/gdb.threads/threadcrash.exp | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/gdb/testsuite/gdb.threads/threadcrash.exp b/gdb/testsuite/gdb.threads/threadcrash.exp index ffbfd83..6da7073 100644 --- a/gdb/testsuite/gdb.threads/threadcrash.exp +++ b/gdb/testsuite/gdb.threads/threadcrash.exp @@ -251,17 +251,15 @@ proc_with_prefix test_gcore {} { } gdb_test "continue" ".*Segmentation fault.*" "continue to crash" - set gcore_name "${::binfile}.gcore" - set gcore_supported [gdb_gcore_cmd "$gcore_name" "saving gcore"] + set gcore_host [host_standard_output_file $::testfile.gcore] + set gcore_supported [gdb_gcore_cmd "$gcore_host" "saving gcore"] if {!$gcore_supported} { unsupported "couldn't generate gcore file" return } - set corefile [gdb_remote_download host $gcore_name] - - gdb_test "core-file $corefile" \ + gdb_test "core-file $gcore_host" \ "" \ "loading_corefile" \ "A program is being debugged already\\\. Kill it\\\? \\\(y or n\\\) " \ |