aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAlan Modra <amodra@gmail.com>2024-04-24 09:30:24 +0930
committerAlan Modra <amodra@gmail.com>2024-04-24 09:33:03 +0930
commit122f6f14b135480b184091bf2037ea133beedc54 (patch)
tree4e901cbce3fa6e446b68e2925ef3bff1137dedcf
parentd65decae83c64c0301f8207bb0bf14ffd11f67b7 (diff)
downloadgdb-122f6f14b135480b184091bf2037ea133beedc54.zip
gdb-122f6f14b135480b184091bf2037ea133beedc54.tar.gz
gdb-122f6f14b135480b184091bf2037ea133beedc54.tar.bz2
buffer overflow in libctf tests
* testsuite/libctf-regression/gzrewrite.c (main): Don't overflow "a" buffer in "after adding types" check. * testsuite/libctf-regression/zrewrite.c (main): Likewise.
-rw-r--r--libctf/testsuite/libctf-regression/gzrewrite.c2
-rw-r--r--libctf/testsuite/libctf-regression/zrewrite.c2
2 files changed, 2 insertions, 2 deletions
diff --git a/libctf/testsuite/libctf-regression/gzrewrite.c b/libctf/testsuite/libctf-regression/gzrewrite.c
index 9972220..2e679e8 100644
--- a/libctf/testsuite/libctf-regression/gzrewrite.c
+++ b/libctf/testsuite/libctf-regression/gzrewrite.c
@@ -114,7 +114,7 @@ main (int argc, char *argv[])
if ((b = read_gz ("tmpdir/two.gz", &b_len)) == NULL)
goto read_err;
- if (memcmp (a, b, b_len) == 0)
+ if (a_len == b_len && memcmp (a, b, b_len) == 0)
{
fprintf (stderr, "gzwrites after adding types does not change the dict\n");
return 1;
diff --git a/libctf/testsuite/libctf-regression/zrewrite.c b/libctf/testsuite/libctf-regression/zrewrite.c
index a88c824..5e061f1 100644
--- a/libctf/testsuite/libctf-regression/zrewrite.c
+++ b/libctf/testsuite/libctf-regression/zrewrite.c
@@ -109,7 +109,7 @@ main (int argc, char *argv[])
b = read_file ("tmpdir/two", &b_len);
- if (memcmp (a, b, b_len) == 0)
+ if (a_len == b_len && memcmp (a, b, b_len) == 0)
{
fprintf (stderr, "compress_writes after adding types does not change the dict\n");
return 1;