diff options
| author | Felix Willgerodt <felix.willgerodt@intel.com> | 2024-05-21 09:20:39 +0200 |
|---|---|---|
| committer | Felix Willgerodt <felix.willgerodt@intel.com> | 2024-05-23 08:19:48 +0200 |
| commit | d3daf5a2ba551707c74813e80be2b53d63a73a25 (patch) | |
| tree | c8c78526fe515c39cd8b0967c438ae0d39272f80 | |
| parent | 100318bcfda243f04cda3c29e8873c5710a1688a (diff) | |
| download | gdb-d3daf5a2ba551707c74813e80be2b53d63a73a25.zip gdb-d3daf5a2ba551707c74813e80be2b53d63a73a25.tar.gz gdb-d3daf5a2ba551707c74813e80be2b53d63a73a25.tar.bz2 | |
gdb, testsuite: Fix return value in gdb.base/foll-fork.exp
In a remote testing setup, I saw this error:
~~~
(gdb) FAIL: gdb.base/foll-fork.exp: check_fork_catchpoints: runto: run to main
ERROR: tcl error sourcing gdb/gdb/testsuite/gdb.base/foll-fork.exp.
ERROR: expected boolean value but got ""
while executing
"if { ![check_fork_catchpoints] } {
untested "follow-fork not supported"
return
}"
(file "gdb/gdb/testsuite/gdb.base/foll-fork.exp" line 434)
invoked from within
"source gdb/gdb/testsuite/gdb.base/foll-fork.exp"
("uplevel" body line 1)
invoked from within
"uplevel #0 source gdb/gdb/testsuite/gdb.base/foll-fork.exp"
invoked from within
"catch "uplevel #0 source $test_file_name""
Remote debugging from host 172.0.1.3, port 37766
Killing process(es): 1171
Quit
~~~
The actual reason for this were some connection problems. Though the
function check_fork_catchpoints shouldn't return an empty string, especially
as it promises to always return 0 or 1. Fix that.
Approved-By: Tom Tromey <tom@tromey.com>
| -rw-r--r-- | gdb/testsuite/gdb.base/foll-fork.exp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/gdb/testsuite/gdb.base/foll-fork.exp b/gdb/testsuite/gdb.base/foll-fork.exp index ecf2111..0d801f0 100644 --- a/gdb/testsuite/gdb.base/foll-fork.exp +++ b/gdb/testsuite/gdb.base/foll-fork.exp @@ -42,7 +42,7 @@ proc_with_prefix check_fork_catchpoints {} { global gdb_prompt if { ![setup] } { - return + return 0 } # Verify that the system supports "catch fork". |