aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTom Tromey <tom@tromey.com>2021-12-11 15:10:14 -0700
committerTom Tromey <tom@tromey.com>2021-12-20 08:49:27 -0700
commitdde238e063376f96d52ff27f11b31a447ddbdfea (patch)
tree12d55ab85c592669dd02d14817f247bea49dc718
parentdb956d66c94de1bc1ff9ac1c38350f14e81c11f6 (diff)
downloadgdb-dde238e063376f96d52ff27f11b31a447ddbdfea.zip
gdb-dde238e063376f96d52ff27f11b31a447ddbdfea.tar.gz
gdb-dde238e063376f96d52ff27f11b31a447ddbdfea.tar.bz2
Make n_spaces return a const char *
n_spaces keeps the spaces in a static buffer. If a caller overwrites these, it may give an incorrect result to a subsequent caller. So, make the return type const to help avoid this outcome.
-rw-r--r--gdb/utils.c2
-rw-r--r--gdb/utils.h2
2 files changed, 2 insertions, 2 deletions
diff --git a/gdb/utils.c b/gdb/utils.c
index e27a881..ea0f65c 100644
--- a/gdb/utils.c
+++ b/gdb/utils.c
@@ -2303,7 +2303,7 @@ puts_unfiltered (const char *string)
/* Return a pointer to N spaces and a null. The pointer is good
until the next call to here. */
-char *
+const char *
n_spaces (int n)
{
char *t;
diff --git a/gdb/utils.h b/gdb/utils.h
index 6f3a702..f6fd32f 100644
--- a/gdb/utils.h
+++ b/gdb/utils.h
@@ -473,7 +473,7 @@ extern void print_spaces (int, struct ui_file *);
extern void print_spaces_filtered (int, struct ui_file *);
-extern char *n_spaces (int);
+extern const char *n_spaces (int);
extern void fputstr_filtered (const char *str, int quotr,
struct ui_file * stream);