aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTom Tromey <tom@tromey.com>2019-11-12 17:02:49 -0700
committerTom Tromey <tom@tromey.com>2019-12-20 09:15:50 -0700
commit039298ec451ecf1fa1b9ff1771168b0a5b3a6f68 (patch)
tree9ecc1833ef4b98dca52cebfd4cdc7efb9eb4cecb
parent8acfefcc8fc7a346d0ecf3d37ca47c5c43761223 (diff)
downloadgdb-039298ec451ecf1fa1b9ff1771168b0a5b3a6f68.zip
gdb-039298ec451ecf1fa1b9ff1771168b0a5b3a6f68.tar.gz
gdb-039298ec451ecf1fa1b9ff1771168b0a5b3a6f68.tar.bz2
Remove some TUI asserts
This removes a few asserts from the TUI. These asserts aren't useful, because they simply check an invariant that's already ensured by the type system. gdb/ChangeLog 2019-12-20 Tom Tromey <tom@tromey.com> * tui/tui-winsource.c (tui_source_window_base::set_is_exec_point_at) (tui_source_window_base::update_breakpoint_info): Remove asserts. Change-Id: I807e1e9bdb0cfa475e70375ceca3a5d4f2eb8d0b
-rw-r--r--gdb/ChangeLog5
-rw-r--r--gdb/tui/tui-winsource.c6
2 files changed, 5 insertions, 6 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 7c518ca..1fc603d 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,10 @@
2019-12-20 Tom Tromey <tom@tromey.com>
+ * tui/tui-winsource.c (tui_source_window_base::set_is_exec_point_at)
+ (tui_source_window_base::update_breakpoint_info): Remove asserts.
+
+2019-12-20 Tom Tromey <tom@tromey.com>
+
* tui/tui-winsource.c (tui_update_source_windows_with_addr): Call
tui_show_disassem.
* tui/tui-disasm.h (tui_show_disassem_and_update_source): Don't
diff --git a/gdb/tui/tui-winsource.c b/gdb/tui/tui-winsource.c
index 06c00fa..fe1eb8f 100644
--- a/gdb/tui/tui-winsource.c
+++ b/gdb/tui/tui-winsource.c
@@ -449,9 +449,6 @@ tui_source_window_base::set_is_exec_point_at (struct tui_line_or_address l)
struct tui_line_or_address content_loa =
content[i].line_or_addr;
- gdb_assert (l.loa == LOA_ADDRESS || l.loa == LOA_LINE);
- gdb_assert (content_loa.loa == LOA_LINE
- || content_loa.loa == LOA_ADDRESS);
if (content_loa.loa == l.loa
&& ((l.loa == LOA_LINE && content_loa.u.line_no == l.u.line_no)
|| (l.loa == LOA_ADDRESS && content_loa.u.addr == l.u.addr)))
@@ -512,9 +509,6 @@ tui_source_window_base::update_breakpoint_info
{
struct bp_location *loc;
- gdb_assert (line->line_or_addr.loa == LOA_LINE
- || line->line_or_addr.loa == LOA_ADDRESS);
-
if (bp == being_deleted)
return false;