diff options
| author | Nick Alcock <nick.alcock@oracle.com> | 2021-03-18 12:37:52 +0000 |
|---|---|---|
| committer | Nick Alcock <nick.alcock@oracle.com> | 2021-03-18 12:40:40 +0000 |
| commit | 2a05d50e90c2c8219dd4119788548f64a934190e (patch) | |
| tree | c0bc0bfd7d5b19dd1a0524af7a25bd16e17907a3 | |
| parent | 755ba58ebef02e1be9fc6770d00243ba6ed0223c (diff) | |
| download | gdb-2a05d50e90c2c8219dd4119788548f64a934190e.zip gdb-2a05d50e90c2c8219dd4119788548f64a934190e.tar.gz gdb-2a05d50e90c2c8219dd4119788548f64a934190e.tar.bz2 | |
libctf: don't lose track of all valid types upon serialization
One pattern which is rarely done in libctf but which is meant to work is
this:
ctf_create();
ctf_add_*(); // add stuff
ctf_type_*() // look stuff up
ctf_write_*();
ctf_add_*(); // should still work
ctf_type_*() // so should this
ctf_write_*(); // and this
i.e., writing out a dict should not break it and you should be able to
do everything you could do with it before, including writing it out
again.
Unfortunately this has been broken for a while because the field which
indicates the maximum valid type ID was not preserved across
serialization: so type additions after serialization would overwrite
types (obviously disastrous) and type lookups would just fail.
Fix trivial.
libctf/ChangeLog
2021-03-18 Nick Alcock <nick.alcock@oracle.com>
* ctf-serialize.c (ctf_serialize): Preserve ctf_typemax across
serialization.
| -rw-r--r-- | libctf/ChangeLog | 5 | ||||
| -rw-r--r-- | libctf/ctf-serialize.c | 1 |
2 files changed, 6 insertions, 0 deletions
diff --git a/libctf/ChangeLog b/libctf/ChangeLog index 3eff44c..c274641 100644 --- a/libctf/ChangeLog +++ b/libctf/ChangeLog @@ -1,5 +1,10 @@ 2021-03-18 Nick Alcock <nick.alcock@oracle.com> + * ctf-serialize.c (ctf_serialize): Preserve ctf_typemax across + serialization. + +2021-03-18 Nick Alcock <nick.alcock@oracle.com> + * ctf-impl.h (ctf_dtdef_t) <dtd_u.dtu_argv>: Remove. * ctf-create.c (ctf_dtd_delete): No longer free it. (ctf_add_function): Use the dtd_vlen, not dtu_argv. Properly align. diff --git a/libctf/ctf-serialize.c b/libctf/ctf-serialize.c index 460ae1a..17f11f6 100644 --- a/libctf/ctf-serialize.c +++ b/libctf/ctf-serialize.c @@ -1113,6 +1113,7 @@ ctf_serialize (ctf_dict_t *fp) nfp->ctf_dynsyms = fp->ctf_dynsyms; nfp->ctf_ptrtab = fp->ctf_ptrtab; nfp->ctf_pptrtab = fp->ctf_pptrtab; + nfp->ctf_typemax = fp->ctf_typemax; nfp->ctf_dynsymidx = fp->ctf_dynsymidx; nfp->ctf_dynsymmax = fp->ctf_dynsymmax; nfp->ctf_ptrtab_len = fp->ctf_ptrtab_len; |