diff options
author | Mark Wielaard <mark@klomp.org> | 2023-01-15 01:06:16 +0100 |
---|---|---|
committer | Mark Wielaard <mark@klomp.org> | 2023-01-30 21:53:57 +0100 |
commit | 214d883794db819617ee60806e3dbeb3d5dab666 (patch) | |
tree | 838d57980c3a6eda4f4324dffe5d33faf88485fb | |
parent | 7d82b08e9e0a7a22943b843972cd1b8ae1328884 (diff) | |
download | gdb-214d883794db819617ee60806e3dbeb3d5dab666.zip gdb-214d883794db819617ee60806e3dbeb3d5dab666.tar.gz gdb-214d883794db819617ee60806e3dbeb3d5dab666.tar.bz2 |
gdb: Replace memcpy with std::copy to avoid some g++ warnings on sparc
For some reason g++ 12.2.1 on sparc produces spurious warnings for
stringop-overread and restrict in fbsd-tdep.c for a memcpy call.
Use std::copy to avoid the warnings:
In function ‘void* memcpy(void*, const void*, size_t)’,
inlined from ‘gdb::optional<std::vector<unsigned char, gdb::default_init_allocator<unsigned char, std::allocator<unsigned char> > > > fbsd_make_note_desc(target_object, uint32_t)’ at ../../binutils-gdb/gdb/fbsd-tdep.c:666:10:
/usr/include/bits/string_fortified.h:29:33: error: ‘void* __builtin_memcpy(void*, const void*, long unsigned int)’ specified bound 18446744073709551612 exceeds maximum object size 9223372036854775807 [-Werror=stringop-overflow=]
In function ‘void* memcpy(void*, const void*, size_t)’,
inlined from ‘gdb::optional<std::vector<unsigned char, gdb::default_init_allocator<unsigned char, std::allocator<unsigned char> > > > fbsd_make_note_desc(target_object, uint32_t)’ at ../../binutils-gdb/gdb/fbsd-tdep.c:673:10:
/usr/include/bits/string_fortified.h:29:33: error: ‘void* __builtin_memcpy(void*, const void*, long unsigned int)’ accessing 18446744073709551612 bytes at offsets 0 and 0 overlaps 9223372036854775801 bytes at offset -9223372036854775805 [-Werror=restrict]
gdb/ChangeLog:
* fbsd-tdep.c (fbsd_make_note_desc): Use std::copy instead
of memcpy.
-rw-r--r-- | gdb/fbsd-tdep.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/gdb/fbsd-tdep.c b/gdb/fbsd-tdep.c index 203390d..3a7cb9b 100644 --- a/gdb/fbsd-tdep.c +++ b/gdb/fbsd-tdep.c @@ -663,7 +663,7 @@ fbsd_make_note_desc (enum target_object object, uint32_t structsize) gdb::byte_vector desc (sizeof (structsize) + buf->size ()); memcpy (desc.data (), &structsize, sizeof (structsize)); - memcpy (desc.data () + sizeof (structsize), buf->data (), buf->size ()); + std::copy (buf->begin (), buf->end (), desc.data () + sizeof (structsize)); return desc; } |