From 43cdf5aeb8ae6ac2ec3bdbf636cbb2731ccbbb2a Mon Sep 17 00:00:00 2001 From: Yao Qi Date: Mon, 5 Oct 2015 11:15:58 +0100 Subject: Pass noaliases_p to aarch64_decode_insn Nowadays aarch64_decode_insn is a public interface used by both opcodes and gdb. However, its behaviour relies on a global variable no_aliases, which isn't a good practise. On the other hand, In default, no_aliases is zero, but in GDB, we do want no alias when decoding instructions for prologue analysis (patches to be posted), so that we can handle both instructions "add" and "mov" (an alias of "add") as "add". The code in GDB can be simplified. This patch adds a new argument in aarch64_decode_insn, and pass no_aliases to it. In GDB side, always pass 1 to it. include/opcode: 2015-10-28 Yao Qi * aarch64.h (aarch64_decode_insn): Update declaration. opcodes: 2015-10-28 Yao Qi * aarch64-dis.c (aarch64_decode_insn): Add one argument noaliases_p. Update comments. Pass noaliases_p rather than no_aliases to aarch64_opcode_decode. (print_insn_aarch64_word): Pass no_aliases to aarch64_decode_insn. gdb: 2015-10-28 Yao Qi * aarch64-tdep.c (aarch64_software_single_step): Pass 1 to aarch64_decode_insn. --- include/opcode/ChangeLog | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'include/opcode/ChangeLog') diff --git a/include/opcode/ChangeLog b/include/opcode/ChangeLog index ea833f73657..b049302318b 100644 --- a/include/opcode/ChangeLog +++ b/include/opcode/ChangeLog @@ -1,3 +1,7 @@ +2015-10-28 Yao Qi + + * aarch64.h (aarch64_decode_insn): Update declaration. + 2015-10-07 Yao Qi * aarch64.h (aarch64_sys_ins_reg)