From 6533cbeeb831224e2d2dd2a7bea54b22b798fa39 Mon Sep 17 00:00:00 2001 From: Johnson Sun Date: Fri, 21 Oct 2022 01:49:18 +0800 Subject: Fix deletion of FinishBreakpoints Currently, FinishBreakpoints are set at the return address of a frame based on the `finish' command, and are meant to be temporary breakpoints. However, they are not being cleaned up after use, as reported in PR python/18655. This was happening because the disposition of the breakpoint was not being set correctly. This commit fixes this issue by correctly setting the disposition in the post-stop hook of the breakpoint. It also adds a test to ensure this feature isn't regressed in the future. Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=18655 --- .../gdb.python/py-finish-breakpoint-deletion.py | 32 ++++++++++++++++++++++ 1 file changed, 32 insertions(+) create mode 100644 gdb/testsuite/gdb.python/py-finish-breakpoint-deletion.py (limited to 'gdb/testsuite/gdb.python/py-finish-breakpoint-deletion.py') diff --git a/gdb/testsuite/gdb.python/py-finish-breakpoint-deletion.py b/gdb/testsuite/gdb.python/py-finish-breakpoint-deletion.py new file mode 100644 index 0000000..ab05b0c --- /dev/null +++ b/gdb/testsuite/gdb.python/py-finish-breakpoint-deletion.py @@ -0,0 +1,32 @@ +# Copyright (C) 2022 Free Software Foundation, Inc. + +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 3 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see . + + +class MyFinishBreakpoint(gdb.FinishBreakpoint): + def stop(self): + print("stopped at MyFinishBreakpoint") + return self.return_value == 4 + + +class MyBreakpoint(gdb.Breakpoint): + def stop(self): + print("stopped at MyBreakpoint") + MyFinishBreakpoint() + return False + + +MyBreakpoint("subroutine", internal=True) + +print("Python script imported") -- cgit v1.1