From e97007b64a388ece1789f6c2cd51d2768e3b4829 Mon Sep 17 00:00:00 2001 From: Simon Marchi Date: Wed, 7 Apr 2021 16:57:29 -0400 Subject: gdb: make target_ops::follow_fork return void I noticed that all implementations return false, so target_ops::follow_fork doesn't really need to return a value. Change it to return void. gdb/ChangeLog: * target.h (struct target_ops) : Return void. (target_follow_fork): Likewise. * target.c (default_follow_fork): Likewise. (target_follow_fork): Likewise. * infrun.c (follow_fork_inferior): Adjust. * fbsd-nat.h (class fbsd_nat_target) : Return void. * fbsd-nat.c (fbsd_nat_target:::follow_fork): Likewise. * linux-nat.h (class linux_nat_target) : Likewise. * linux-nat.c (linux_nat_target::follow_fork): Return void. * obsd-nat.h (class obsd_nat_target) : Return void. * obsd-nat.c (obsd_nat_target::follow_fork): Likewise. * remote.c (class remote_target) : Likewise. (remote_target::follow_fork): Likewise. * target-delegates.c: Re-generate. Change-Id: If908c2f68b29fa275be2b0b9deb41e4c6a1b7879 --- gdb/target-delegates.c | 22 +++++++++------------- 1 file changed, 9 insertions(+), 13 deletions(-) (limited to 'gdb/target-delegates.c') diff --git a/gdb/target-delegates.c b/gdb/target-delegates.c index cc8c64a..ef8c94c 100644 --- a/gdb/target-delegates.c +++ b/gdb/target-delegates.c @@ -56,7 +56,7 @@ struct dummy_target : public target_ops int remove_fork_catchpoint (int arg0) override; int insert_vfork_catchpoint (int arg0) override; int remove_vfork_catchpoint (int arg0) override; - bool follow_fork (bool arg0, bool arg1) override; + void follow_fork (bool arg0, bool arg1) override; int insert_exec_catchpoint (int arg0) override; int remove_exec_catchpoint (int arg0) override; void follow_exec (struct inferior *arg0, const char *arg1) override; @@ -231,7 +231,7 @@ struct debug_target : public target_ops int remove_fork_catchpoint (int arg0) override; int insert_vfork_catchpoint (int arg0) override; int remove_vfork_catchpoint (int arg0) override; - bool follow_fork (bool arg0, bool arg1) override; + void follow_fork (bool arg0, bool arg1) override; int insert_exec_catchpoint (int arg0) override; int remove_exec_catchpoint (int arg0) override; void follow_exec (struct inferior *arg0, const char *arg1) override; @@ -1518,32 +1518,28 @@ debug_target::remove_vfork_catchpoint (int arg0) return result; } -bool +void target_ops::follow_fork (bool arg0, bool arg1) { - return this->beneath ()->follow_fork (arg0, arg1); + this->beneath ()->follow_fork (arg0, arg1); } -bool +void dummy_target::follow_fork (bool arg0, bool arg1) { - return default_follow_fork (this, arg0, arg1); + default_follow_fork (this, arg0, arg1); } -bool +void debug_target::follow_fork (bool arg0, bool arg1) { - bool result; fprintf_unfiltered (gdb_stdlog, "-> %s->follow_fork (...)\n", this->beneath ()->shortname ()); - result = this->beneath ()->follow_fork (arg0, arg1); + this->beneath ()->follow_fork (arg0, arg1); fprintf_unfiltered (gdb_stdlog, "<- %s->follow_fork (", this->beneath ()->shortname ()); target_debug_print_bool (arg0); fputs_unfiltered (", ", gdb_stdlog); target_debug_print_bool (arg1); - fputs_unfiltered (") = ", gdb_stdlog); - target_debug_print_bool (result); - fputs_unfiltered ("\n", gdb_stdlog); - return result; + fputs_unfiltered (")\n", gdb_stdlog); } int -- cgit v1.1