From a5cbe67512d3cfb1767733c8de74b70b45ebe052 Mon Sep 17 00:00:00 2001 From: Simon Marchi Date: Fri, 10 Oct 2025 23:59:32 -0400 Subject: gdb, gdbserver, gdbsupport: trim trailing whitespaces I noticed my IDE (VSCode) starting to automatically trim trailing whitespaces on save, despite the setting for it being disabled. I realized that this is because the .editorconfig file now has trim_trailing_whitespace = true for many file types. If we have this EditorConfig setting forcing editors to trim trailing whitespaces, I think it would make sense to clean up trailing whitespaces from our files. Otherwise, people will always get spurious whitespace changes when editing these files. I did a mass cleanup using this command: $ find gdb gdbserver gdbsupport -type f \( \ -name "*.c" -o \ -name "*.h" -o \ -name "*.cc" -o \ -name "*.texi" -o \ -name "*.exp" -o \ -name "*.tcl" -o \ -name "*.py" -o \ -name "*.s" -o \ -name "*.S" -o \ -name "*.asm" -o \ -name "*.awk" -o \ -name "*.ac" -o \ -name "Makefile*" -o \ -name "*.sh" -o \ -name "*.adb" -o \ -name "*.ads" -o \ -name "*.d" -o \ -name "*.go" -o \ -name "*.F90" -o \ -name "*.f90" \ \) -exec sed -ri 's/[ \t]+$//' {} + I then did an autotools regen, because we don't actually want to change the Makefile and Makefile.in files that are generated. Change-Id: I6f91b83e3b8c4dc7d5d51a2ebf60706120efe691 --- gdb/python/python-internal.h | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) (limited to 'gdb/python/python-internal.h') diff --git a/gdb/python/python-internal.h b/gdb/python/python-internal.h index 51ace132ddc..e2baa6a70b5 100644 --- a/gdb/python/python-internal.h +++ b/gdb/python/python-internal.h @@ -1165,7 +1165,7 @@ gdbpy_type_ready (PyTypeObject *type, PyObject *mod = nullptr) # define PyType_Ready POISONED_PyType_Ready #endif -/* A class to manage lifecycle of Python objects for objects that are "owned" +/* A class to manage lifecycle of Python objects for objects that are "owned" by an objfile or a gdbarch. It keeps track of Python objects and when the "owning" object (objfile or gdbarch) is about to be freed, ensures that all Python objects "owned" by that object are properly invalidated. @@ -1175,9 +1175,9 @@ gdbpy_type_ready (PyTypeObject *type, PyObject *mod = nullptr) on demand and it is deleted when owning object is about to be freed. The storage class must provide two member types: - - * obj_type - the type of Python object whose lifecycle is managed. - * val_type - the type of GDB structure the Python objects are + + * obj_type - the type of Python object whose lifecycle is managed. + * val_type - the type of GDB structure the Python objects are representing. It must also provide following methods: @@ -1266,9 +1266,9 @@ struct gdbpy_default_invalidator }; /* A "storage" implementation suitable for temporary (on-demand) objects. */ -template > class gdbpy_tracking_registry_storage { @@ -1280,7 +1280,7 @@ public: { gdb_assert (obj != nullptr && obj->*val_slot != nullptr); - m_objects.insert (obj); + m_objects.insert (obj); } void remove (obj_type *obj) @@ -1288,7 +1288,7 @@ public: gdb_assert (obj != nullptr && obj->*val_slot != nullptr); gdb_assert (m_objects.contains (obj)); - m_objects.erase (obj); + m_objects.erase (obj); } ~gdbpy_tracking_registry_storage () @@ -1311,9 +1311,9 @@ protected: drops all their references the Python object is deallocated and removed from storage. */ -template > class gdbpy_memoizing_registry_storage { -- cgit v1.2.3