From 0735b091aba72d4b35aebb671a02c5cb4a837fe9 Mon Sep 17 00:00:00 2001 From: Tom Tromey Date: Tue, 30 Apr 2019 11:17:15 -0600 Subject: Do not emit style escape sequences to log file PR gdb/24502 requests that the "set logging" log file not contain style escape sequences emitted by gdb. This seemed like a reasonable request to me, so this patch implements filtering for the log file. This also updates a comment in ui-style.h that I noticed while writing the patch. Tested on x86-64 Fedora 29. gdb/ChangeLog 2019-06-14 Tom Tromey PR gdb/24502: * ui-style.h (skip_ansi_escape): Update comment. * ui-file.h (class no_terminal_escape_file): New class. * ui-file.c (no_terminal_escape_file::write) (no_terminal_escape_file::puts): New methods. * cli/cli-logging.c (handle_redirections): Use no_terminal_escape_file. gdb/testsuite/ChangeLog 2019-06-14 Tom Tromey PR gdb/24502: * gdb.base/style-logging.exp: New file. --- gdb/cli/cli-logging.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'gdb/cli/cli-logging.c') diff --git a/gdb/cli/cli-logging.c b/gdb/cli/cli-logging.c index bef5f39..a8b9955 100644 --- a/gdb/cli/cli-logging.c +++ b/gdb/cli/cli-logging.c @@ -100,7 +100,7 @@ handle_redirections (int from_tty) return; } - stdio_file_up log (new stdio_file ()); + stdio_file_up log (new no_terminal_escape_file ()); if (!log->open (logging_filename, logging_overwrite ? "w" : "a")) perror_with_name (_("set logging")); -- cgit v1.1