diff options
| author | Alan Modra <amodra@gmail.com> | 2021-07-02 17:27:31 +0930 |
|---|---|---|
| committer | Alan Modra <amodra@gmail.com> | 2021-07-02 20:48:55 +0930 |
| commit | 62194b631d00112bac1f8856d3259d774df4c15e (patch) | |
| tree | cd7385f4fdfbd31d5773180313cea95c3b340bdf /opcodes/nds32-dis.c | |
| parent | af82b082c27eeefa261753e746fd002cc528cd1f (diff) | |
| download | binutils-62194b631d00112bac1f8856d3259d774df4c15e.zip binutils-62194b631d00112bac1f8856d3259d774df4c15e.tar.gz binutils-62194b631d00112bac1f8856d3259d774df4c15e.tar.bz2 | |
Re: Fix minor NDS32 renaming snafu
Some extern declarations differ in constnes to their definitions too.
Let's make sure this sort of thing doesn't happen again, but putting
the externs in a header where they belong.
gas/
* config/tc-nds32.c (nds32_keyword_gpr): Don't declare.
(md_begin): Constify k.
opcodes/
* nds32-dis.c (nds32_find_reg_keyword): Constify arg and return.
(nds32_parse_audio_ext, nds32_parse_opcode): Constify psys_reg.
(nds32_field_table, nds32_opcode_table, nds32_keyword_table),
(nds32_opcodes, nds32_operand_fields, nds32_keywords),
(nds32_keyword_gpr): Move declarations to..
* nds32-asm.h: ..here, constifying to match definitions.
Diffstat (limited to 'opcodes/nds32-dis.c')
| -rw-r--r-- | opcodes/nds32-dis.c | 16 |
1 files changed, 4 insertions, 12 deletions
diff --git a/opcodes/nds32-dis.c b/opcodes/nds32-dis.c index c888487..c8cb506 100644 --- a/opcodes/nds32-dis.c +++ b/opcodes/nds32-dis.c @@ -65,14 +65,6 @@ struct nds32_private_data #define NDS32_PARSE_INSN16 0x01 #define NDS32_PARSE_INSN32 0x02 -extern const field_t *nds32_field_table[NDS32_CORE_COUNT]; -extern opcode_t *nds32_opcode_table[NDS32_CORE_COUNT]; -extern keyword_t **nds32_keyword_table[NDS32_CORE_COUNT]; -extern struct nds32_opcode nds32_opcodes[]; -extern const field_t nds32_operand_fields[]; -extern keyword_t *nds32_keywords[]; -extern const keyword_t nds32_keyword_gpr[]; - static uint32_t nds32_mask_opcode (uint32_t); static void nds32_special_opcode (uint32_t, struct nds32_opcode **); static int get_mapping_symbol_type (struct disassemble_info *, int, @@ -86,8 +78,8 @@ static htab_t opcode_htab; /* Find the value map register name. */ -static keyword_t * -nds32_find_reg_keyword (keyword_t *reg, int value) +static const keyword_t * +nds32_find_reg_keyword (const keyword_t *reg, int value) { if (!reg) return NULL; @@ -107,7 +99,7 @@ nds32_parse_audio_ext (const field_t *pfd, { fprintf_ftype func = info->fprintf_func; void *stream = info->stream; - keyword_t *psys_reg; + const keyword_t *psys_reg; int int_value, new_value; if (pfd->hw_res == HW_INT || pfd->hw_res == HW_UINT) @@ -224,7 +216,7 @@ nds32_parse_opcode (struct nds32_opcode *opc, bfd_vma pc ATTRIBUTE_UNUSED, unsigned int push25gpr = 0, lsmwRb, lsmwRe, lsmwEnb4, checkbit, i; int int_value, ifthe1st = 1; const field_t *pfd; - keyword_t *psys_reg; + const keyword_t *psys_reg; if (opc == NULL) { |