aboutsummaryrefslogtreecommitdiff
path: root/libctf/testsuite/libctf-regression/open-error-free.c
diff options
context:
space:
mode:
authorNick Alcock <nick.alcock@oracle.com>2024-06-12 11:08:39 +0100
committerNick Alcock <nick.alcock@oracle.com>2024-06-18 13:20:32 +0100
commit9f0fb75b8e121a93b0f63dd823fa86ffd44e8e5d (patch)
treeb4419583d8c06b014b1097d28680035f112640fa /libctf/testsuite/libctf-regression/open-error-free.c
parente3cd5660756223bbe4a2ab607ef019bbf5e9daf9 (diff)
downloadbinutils-9f0fb75b8e121a93b0f63dd823fa86ffd44e8e5d.zip
binutils-9f0fb75b8e121a93b0f63dd823fa86ffd44e8e5d.tar.gz
binutils-9f0fb75b8e121a93b0f63dd823fa86ffd44e8e5d.tar.bz2
libctf: suppress spurious failure of malloc-counting tests under valgrind
The libctf-regression/open-error-free.c test works by interposing malloc and counting mallocs and frees across libctf operations. This only works under suitably-interposable mallocs on systems supporting dlsym (RTLD_NEXT, ...), so its operation is restricted to glibc systems for now, but also it interacts badly with valgrind, which interposes malloc itself. Detect a running valgrind and skip the test. Add new facilities allowing libctf lookup tests to declare themselves unsupported, by printing "UNSUPPORTED: " and then some meaningful message instead of their normal output. libctf/ * configure.ac: Check for <valgrind/valgrind.h>. * config.h.in: Regenerate. * configure: Likewise. * testsuite/lib/ctf-lib.exp (run_lookup_test): Add support for UNSUPPORTED tests. * testsuite/libctf-regression/open-error-free.c: When running under valgrind, this test is unsupported.
Diffstat (limited to 'libctf/testsuite/libctf-regression/open-error-free.c')
-rw-r--r--libctf/testsuite/libctf-regression/open-error-free.c13
1 files changed, 13 insertions, 0 deletions
diff --git a/libctf/testsuite/libctf-regression/open-error-free.c b/libctf/testsuite/libctf-regression/open-error-free.c
index 5e48744..edc5f34 100644
--- a/libctf/testsuite/libctf-regression/open-error-free.c
+++ b/libctf/testsuite/libctf-regression/open-error-free.c
@@ -1,6 +1,7 @@
/* Make sure that, on error, an opened dict is properly freed. */
#define _GNU_SOURCE 1
+#include "config.h"
#include <dlfcn.h>
#include <stdio.h>
#include <stdlib.h>
@@ -8,6 +9,10 @@
#include <ctf-api.h>
#include <ctf.h>
+#ifdef HAVE_VALGRIND_VALGRIND_H
+#include <valgrind/valgrind.h>
+#endif
+
static unsigned long long malloc_count;
static unsigned long long free_count;
@@ -111,6 +116,14 @@ int main (void)
ctf_next_t *it = NULL;
unsigned long long frozen_malloc_count, frozen_free_count;
+#ifdef HAVE_VALGRIND_VALGRIND_H
+ if (RUNNING_ON_VALGRIND)
+ {
+ printf ("UNSUPPORTED: valgrind interferes with malloc counting\n");
+ return 0;
+ }
+#endif
+
if ((fp = ctf_create (&err)) == NULL)
goto open_err;