aboutsummaryrefslogtreecommitdiff
path: root/gdbserver
diff options
context:
space:
mode:
authorSimon Marchi <simon.marchi@polymtl.ca>2021-01-20 20:55:05 -0500
committerSimon Marchi <simon.marchi@polymtl.ca>2021-01-20 20:55:05 -0500
commit6bd434d6caa4c08a5ea87fe327d802c1e00a5c5e (patch)
treea4594767b41b738b1003388904f1e9593d0d7c3d /gdbserver
parenta6c11cbb14cea4900a97f8cb20762fefec6fda54 (diff)
downloadbinutils-6bd434d6caa4c08a5ea87fe327d802c1e00a5c5e.zip
binutils-6bd434d6caa4c08a5ea87fe327d802c1e00a5c5e.tar.gz
binutils-6bd434d6caa4c08a5ea87fe327d802c1e00a5c5e.tar.bz2
gdb: make some variables static
I'm trying to enable clang's -Wmissing-variable-declarations warning. This patch fixes all the obvious spots where we can simply add "static" (at least, found when building on x86-64 Linux). gdb/ChangeLog: * aarch64-linux-tdep.c (aarch64_linux_record_tdep): Make static. * aarch64-tdep.c (tdesc_aarch64_list, aarch64_prologue_unwind, aarch64_stub_unwind, aarch64_normal_base, ): Make static. * arm-linux-tdep.c (arm_prologue_unwind): Make static. * arm-tdep.c (struct frame_unwind): Make static. * auto-load.c (auto_load_safe_path_vec): Make static. * csky-tdep.c (csky_stub_unwind): Make static. * gdbarch.c (gdbarch_data_registry): Make static. * gnu-v2-abi.c (gnu_v2_abi_ops): Make static. * i386-netbsd-tdep.c (i386nbsd_mc_reg_offset): Make static. * i386-tdep.c (i386_frame_setup_skip_insns, i386_tramp_chain_in_reg_insns, i386_tramp_chain_on_stack_insns): Make static. * infrun.c (observer_mode): Make static. * linux-nat.c (sigchld_action): Make static. * linux-thread-db.c (thread_db_list): Make static. * maint-test-options.c (maintenance_test_options_list): * mep-tdep.c (mep_csr_registers): Make static. * mi/mi-cmds.c (struct mi_cmd_stats): Remove struct type name. (stats): Make static. * nat/linux-osdata.c (struct osdata_type): Make static. * ppc-netbsd-tdep.c (ppcnbsd_reg_offsets): Make static. * progspace.c (last_program_space_num): Make static. * python/py-param.c (struct parm_constant): Remove struct type name. (parm_constants): Make static. * python/py-record-btrace.c (btpy_list_methods): Make static. * python/py-record.c (recpy_gap_type): Make static. * record.c (record_goto_cmdlist): Make static. * regcache.c (regcache_descr_handle): Make static. * registry.h (DEFINE_REGISTRY): Make definition static. * symmisc.c (std_in, std_out, std_err): Make static. * top.c (previous_saved_command_line): Make static. * tracepoint.c (trace_user, trace_notes, trace_stop_notes): Make static. * unittests/command-def-selftests.c (nr_duplicates, nr_invalid_prefixcmd, lists): Make static. * unittests/observable-selftests.c (test_notification): Make static. * unittests/optional/assignment/1.cc (counter): Make static. * unittests/optional/assignment/2.cc (counter): Make static. * unittests/optional/assignment/3.cc (counter): Make static. * unittests/optional/assignment/4.cc (counter): Make static. * unittests/optional/assignment/5.cc (counter): Make static. * unittests/optional/assignment/6.cc (counter): Make static. gdbserver/ChangeLog: * ax.cc (bytecode_address_table): Make static. * debug.cc (debug_file): Make static. * linux-low.cc (stopping_threads): Make static. (step_over_bkpt): Make static. * linux-x86-low.cc (amd64_emit_ops, i386_emit_ops): Make static. * tracepoint.cc (stop_tracing_bkpt, flush_trace_buffer_bkpt, alloced_trace_state_variables, trace_buffer_ctrl, tracing_start_time, tracing_stop_time, tracing_user_name, tracing_notes, tracing_stop_note): Make static. Change-Id: Ic1d8034723b7802502bda23770893be2338ab020
Diffstat (limited to 'gdbserver')
-rw-r--r--gdbserver/ChangeLog12
-rw-r--r--gdbserver/ax.cc2
-rw-r--r--gdbserver/debug.cc2
-rw-r--r--gdbserver/linux-low.cc4
-rw-r--r--gdbserver/linux-x86-low.cc4
-rw-r--r--gdbserver/tracepoint.cc18
6 files changed, 27 insertions, 15 deletions
diff --git a/gdbserver/ChangeLog b/gdbserver/ChangeLog
index 7231d9a..2f883e0 100644
--- a/gdbserver/ChangeLog
+++ b/gdbserver/ChangeLog
@@ -1,3 +1,15 @@
+2021-01-20 Simon Marchi <simon.marchi@polymtl.ca>
+
+ * ax.cc (bytecode_address_table): Make static.
+ * debug.cc (debug_file): Make static.
+ * linux-low.cc (stopping_threads): Make static.
+ (step_over_bkpt): Make static.
+ * linux-x86-low.cc (amd64_emit_ops, i386_emit_ops): Make static.
+ * tracepoint.cc (stop_tracing_bkpt, flush_trace_buffer_bkpt,
+ alloced_trace_state_variables, trace_buffer_ctrl,
+ tracing_start_time, tracing_stop_time, tracing_user_name,
+ tracing_notes, tracing_stop_note): Make static.
+
2021-01-20 Tom de Vries <tdevries@suse.de>
* linux-x86-low.cc (collect_register_i386): New function.
diff --git a/gdbserver/ax.cc b/gdbserver/ax.cc
index 9a968c5..a217a3d 100644
--- a/gdbserver/ax.cc
+++ b/gdbserver/ax.cc
@@ -146,7 +146,7 @@ CORE_ADDR current_insn_ptr;
int emit_error;
-struct bytecode_address
+static struct bytecode_address
{
int pc;
CORE_ADDR address;
diff --git a/gdbserver/debug.cc b/gdbserver/debug.cc
index b3a5fe1..12f6db0 100644
--- a/gdbserver/debug.cc
+++ b/gdbserver/debug.cc
@@ -24,7 +24,7 @@ int remote_debug = 0;
#endif
/* Output file for debugging. Default to standard error. */
-FILE *debug_file = stderr;
+static FILE *debug_file = stderr;
/* See debug.h. */
int debug_threads;
diff --git a/gdbserver/linux-low.cc b/gdbserver/linux-low.cc
index 4b43d17..d167914 100644
--- a/gdbserver/linux-low.cc
+++ b/gdbserver/linux-low.cc
@@ -253,7 +253,7 @@ enum stopping_threads_kind
};
/* This is set while stop_all_lwps is in effect. */
-enum stopping_threads_kind stopping_threads = NOT_STOPPING_THREADS;
+static stopping_threads_kind stopping_threads = NOT_STOPPING_THREADS;
/* FIXME make into a target method? */
int using_threads = 1;
@@ -272,7 +272,7 @@ static int check_ptrace_stopped_lwp_gone (struct lwp_info *lp);
/* When the event-loop is doing a step-over, this points at the thread
being stepped. */
-ptid_t step_over_bkpt;
+static ptid_t step_over_bkpt;
bool
linux_process_target::low_supports_breakpoints ()
diff --git a/gdbserver/linux-x86-low.cc b/gdbserver/linux-x86-low.cc
index d3273a1..58ca4ba 100644
--- a/gdbserver/linux-x86-low.cc
+++ b/gdbserver/linux-x86-low.cc
@@ -2219,7 +2219,7 @@ amd64_emit_ge_goto (int *offset_p, int *size_p)
*size_p = 4;
}
-struct emit_ops amd64_emit_ops =
+static emit_ops amd64_emit_ops =
{
amd64_emit_prologue,
amd64_emit_epilogue,
@@ -2888,7 +2888,7 @@ i386_emit_ge_goto (int *offset_p, int *size_p)
*size_p = 4;
}
-struct emit_ops i386_emit_ops =
+static emit_ops i386_emit_ops =
{
i386_emit_prologue,
i386_emit_epilogue,
diff --git a/gdbserver/tracepoint.cc b/gdbserver/tracepoint.cc
index 5c5dac0..bc8fb26 100644
--- a/gdbserver/tracepoint.cc
+++ b/gdbserver/tracepoint.cc
@@ -402,11 +402,11 @@ tracepoint_handler (CORE_ADDR address)
}
/* Breakpoint at "stop_tracing" in the inferior lib. */
-struct breakpoint *stop_tracing_bkpt;
+static struct breakpoint *stop_tracing_bkpt;
static int stop_tracing_handler (CORE_ADDR);
/* Breakpoint at "flush_trace_buffer" in the inferior lib. */
-struct breakpoint *flush_trace_buffer_bkpt;
+static struct breakpoint *flush_trace_buffer_bkpt;
static int flush_trace_buffer_handler (CORE_ADDR);
static void download_trace_state_variables (void);
@@ -912,7 +912,7 @@ struct trace_state_variable
/* Linked list of all trace state variables. */
#ifdef IN_PROCESS_AGENT
-struct trace_state_variable *alloced_trace_state_variables;
+static struct trace_state_variable *alloced_trace_state_variables;
#endif
IP_AGENT_EXPORT_VAR struct trace_state_variable *trace_state_variables;
@@ -1170,7 +1170,7 @@ IP_AGENT_EXPORT_VAR unsigned int trace_buffer_ctrl_curr;
it doesn't need to sync with itself. Define it as array anyway so
that the rest of the code base doesn't need to care for the
difference. */
-struct trace_buffer_control trace_buffer_ctrl[1];
+static trace_buffer_control trace_buffer_ctrl[1];
# define TRACE_BUFFER_CTRL_CURR 0
#endif
@@ -1264,23 +1264,23 @@ static int tracing_stop_tpnum;
/* 64-bit timestamps for the trace run's start and finish, expressed
in microseconds from the Unix epoch. */
-LONGEST tracing_start_time;
-LONGEST tracing_stop_time;
+static LONGEST tracing_start_time;
+static LONGEST tracing_stop_time;
/* The (optional) user-supplied name of the user that started the run.
This is an arbitrary string, and may be NULL. */
-char *tracing_user_name;
+static char *tracing_user_name;
/* Optional user-supplied text describing the run. This is
an arbitrary string, and may be NULL. */
-char *tracing_notes;
+static char *tracing_notes;
/* Optional user-supplied text explaining a tstop command. This is an
arbitrary string, and may be NULL. */
-char *tracing_stop_note;
+static char *tracing_stop_note;
#endif