aboutsummaryrefslogtreecommitdiff
path: root/gdb/source.c
diff options
context:
space:
mode:
authorGeorg Sauthoff <mail@georg.so>2018-03-01 17:23:31 -0500
committerSimon Marchi <simon.marchi@ericsson.com>2018-03-01 17:28:59 -0500
commite1e6f073a9f5d7c3183cb8096fb24a42c28ba36b (patch)
treebcc7427f71ad3cf1c2bab8ae3d4e0457c308234a /gdb/source.c
parent788af978df01c3667be99a1607b774f5fa844113 (diff)
downloadbinutils-e1e6f073a9f5d7c3183cb8096fb24a42c28ba36b.zip
binutils-e1e6f073a9f5d7c3183cb8096fb24a42c28ba36b.tar.gz
binutils-e1e6f073a9f5d7c3183cb8096fb24a42c28ba36b.tar.bz2
Improve gcore shell quoting and portability
The gcore shell script (gdb/gcore.in) doesn't quote its variables enough. For example, trying to write a core file with - say - a space ungraciously fails like this: $ gcore -o 'foo bar' 6270 /usr/bin/gcore: line 92: [: foo: binary operator expected gcore: failed to create foo bar.6270 Similarly, one can inject meta characters like * (by accident) that may yield unexpected results, e.g. as in: $ gcore -o foobar '*' This change fixes these issues in several places. Aso, since the script uses array syntax, the patch changes the the shell in the first line from `/bin/sh` to /bin/bash`. POSIX doesn't specify the array syntax for shell, thus, the script doesn't work on systems where /bin/sh is linked to - say - dash. Since the source gcore.in already is processed by a pre-processor one could even auto-detect the path to bash and thus dynamically generate the first line. For systems where bash isn't available via /bin/bash. But I think this would be overkill and /bin/bash is good enough as most systems probably have it. gdb/ChangeLog: PR gdb/22888 * gcore.in: Quote variables and switch interpreter to bash.
Diffstat (limited to 'gdb/source.c')
0 files changed, 0 insertions, 0 deletions