diff options
| author | Tom Tromey <tromey@adacore.com> | 2019-02-06 15:14:40 +0100 |
|---|---|---|
| committer | Tom Tromey <tromey@adacore.com> | 2019-02-15 13:53:43 -0700 |
| commit | 485b851b68ea035e3c49234dafcddb97c4f54a30 (patch) | |
| tree | ee41d3c5c194af0b04790991e58689d436c04ff1 /gdb/source.c | |
| parent | 0b790b1eeb3741217d4b7b419aca1ed77a114b6c (diff) | |
| download | binutils-485b851b68ea035e3c49234dafcddb97c4f54a30.zip binutils-485b851b68ea035e3c49234dafcddb97c4f54a30.tar.gz binutils-485b851b68ea035e3c49234dafcddb97c4f54a30.tar.bz2 | |
Special-case wildcard requests in ravenscar-thread.c
ravenscar-thread.c intercepts resume and wait target requests and
replaces the requested ptid with the ptid of the underlying CPU.
However, this is incorrect when a request is made with a wildcard
ptid.
This patch adds a special case to ravenscar-thread.c for
minus_one_ptid. I don't believe a special case for process wildcards
is necessary, so I have not added that.
Joel's description explains the bug well:
At the user level, we noticed the issue because we had a test were
we insert a breakpoint one some code which is only run from, say,
CPU #2, whereas we unfortunately resumed the execution after having
stopped somewhere in CPU #1. As a result, we sent an order to resume
CPU #1, which starves CPU #2 forever, because the code in CPU #1
waits for some of the Ada tasks allocated to CPU #2 (and we never
reach our breakpoint either).
gdb/ChangeLog
2019-02-15 Tom Tromey <tromey@adacore.com>
* ravenscar-thread.c (ravenscar_thread_target::resume)
(ravenscar_thread_target::wait): Special case wildcard requests.
Diffstat (limited to 'gdb/source.c')
0 files changed, 0 insertions, 0 deletions