diff options
| author | Alan Modra <amodra@gmail.com> | 2024-03-28 19:25:42 +1030 |
|---|---|---|
| committer | Alan Modra <amodra@gmail.com> | 2024-04-02 10:32:04 +1030 |
| commit | af969b14aedcc0ae27dcefab4327ff2d153dec8b (patch) | |
| tree | 0798575242610edd85068427a07f486ee5750660 /bfd/elfnn-loongarch.c | |
| parent | f37f8c46c2e876a524301d6916a04cf7debb6483 (diff) | |
| download | binutils-af969b14aedcc0ae27dcefab4327ff2d153dec8b.zip binutils-af969b14aedcc0ae27dcefab4327ff2d153dec8b.tar.gz binutils-af969b14aedcc0ae27dcefab4327ff2d153dec8b.tar.bz2 | |
PR 30569, always call elf_backend_size_dynamic_sections
This largely mechanical patch is preparation for a followup patch.
For quite some time I've thought that it would be useful to call
elf_backend_size_dynamic_sections even when no dynamic objects are
seen by the linker. That's what this patch does, with some renaming.
There are no functional changes to the linker, just a move of the
dynobj test in bfd_elf_size_dynamic_sections to target backend
functions, replacing the asserts/aborts already there. No doubt some
of the current always_size_sections functions could be moved to
size_dynamic_sections but I haven't made that change.
Because both hooks are now always called, I have renamed
always_size_sections to early_size_sections and size_dynamic_sections
to late_size_sections. I condisdered calling late_size_sections plain
size_sections, since this is the usual target dynamic section sizing
hook, but decided that searching the sources for "size_sections" would
then hit early_size_sections and other functions.
Diffstat (limited to 'bfd/elfnn-loongarch.c')
| -rw-r--r-- | bfd/elfnn-loongarch.c | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/bfd/elfnn-loongarch.c b/bfd/elfnn-loongarch.c index 952c42d..eb70799 100644 --- a/bfd/elfnn-loongarch.c +++ b/bfd/elfnn-loongarch.c @@ -1741,8 +1741,8 @@ maybe_set_textrel (struct elf_link_hash_entry *h, void *info_p) } static bool -loongarch_elf_size_dynamic_sections (bfd *output_bfd, - struct bfd_link_info *info) +loongarch_elf_late_size_sections (bfd *output_bfd, + struct bfd_link_info *info) { struct loongarch_elf_link_hash_table *htab; bfd *dynobj; @@ -1752,7 +1752,8 @@ loongarch_elf_size_dynamic_sections (bfd *output_bfd, htab = loongarch_elf_hash_table (info); BFD_ASSERT (htab != NULL); dynobj = htab->elf.dynobj; - BFD_ASSERT (dynobj != NULL); + if (dynobj == NULL) + return true; if (htab->elf.dynamic_sections_created) { @@ -5497,7 +5498,7 @@ loongarch_elf_is_rela_normal (Elf_Internal_Rela *rel) loongarch_elf_create_dynamic_sections #define elf_backend_check_relocs loongarch_elf_check_relocs #define elf_backend_adjust_dynamic_symbol loongarch_elf_adjust_dynamic_symbol -#define elf_backend_size_dynamic_sections loongarch_elf_size_dynamic_sections +#define elf_backend_late_size_sections loongarch_elf_late_size_sections #define elf_backend_relocate_section loongarch_elf_relocate_section #define elf_backend_finish_dynamic_symbol loongarch_elf_finish_dynamic_symbol #define elf_backend_output_arch_local_syms \ |