From 39d744bdccbb16bcd4681fbb850dafc9c63c4e25 Mon Sep 17 00:00:00 2001
From: Alan Modra <amodra@gmail.com>
Date: Mon, 3 Aug 2020 10:57:09 +0930
Subject: Tidy objdump_symstuff and objdump_dynsymstuff

	* testsuite/ld-elfvers/vers.exp (objdump_symstuff): Remove unused
	variable.  Init list_a and list_b to empty.
	(objdump_dynsymstuff): Likewise, and remove undefined list_a
	handling.
	* testsuite/ld-elfweak/elfweak.exp (objdump_symstuff): Similarly.
	(objdump_dynsymstuff): Similarly.
---
 ld/testsuite/ld-elfweak/elfweak.exp | 21 ++++++---------------
 1 file changed, 6 insertions(+), 15 deletions(-)

(limited to 'ld/testsuite/ld-elfweak')

diff --git a/ld/testsuite/ld-elfweak/elfweak.exp b/ld/testsuite/ld-elfweak/elfweak.exp
index 85da211..3481878 100644
--- a/ld/testsuite/ld-elfweak/elfweak.exp
+++ b/ld/testsuite/ld-elfweak/elfweak.exp
@@ -103,7 +103,8 @@ proc objdump_symstuff { objdump object expectfile } {
 	verbose "# Diff'ing: $expectfile $tmpdir/objdump.out" 2
 
 	set eof -1
-	set differences 0
+	set list_a {}
+	set list_b {}
 
 	while { [gets $file_a line] != $eof } {
 	    if [regexp "^#.*$" $line] then {
@@ -128,7 +129,6 @@ proc objdump_symstuff { objdump object expectfile } {
 	    set line_a [lindex $list_a $i]
 	    set line_b [lindex $list_b $i]
 
-
 	    verbose "\t$expectfile: $i: $line_a" 3
 	    verbose "\t/tmp/objdump.out: $i: $line_b" 3
 	    if [regexp $line_a $line_b] then {
@@ -145,17 +145,12 @@ proc objdump_symstuff { objdump object expectfile } {
 	    verbose -log "Line count"
 	    return 0
 	}
+	return 1
 
-	if $differences<1 then {
-	    return 1
-	}
-
-	return 0
     } else {
 	verbose -log "$exec_output"
 	return 0
     }
-
 }
 
 #
@@ -199,7 +194,8 @@ proc objdump_dynsymstuff { objdump object expectfile } {
 	verbose "# Diff'ing: $expectfile $tmpdir/objdump.out" 2
 
 	set eof -1
-	set differences 0
+	set list_a {}
+	set list_b {}
 
 	while { [gets $file_a line] != $eof } {
 	    if [regexp "^#.*$" $line] then {
@@ -256,17 +252,12 @@ proc objdump_dynsymstuff { objdump object expectfile } {
 	    verbose -log "Line count"
 	    return 0
 	}
+	return 1
 
-	if $differences<1 then {
-	    return 1
-	}
-
-	return 0
     } else {
 	verbose -log "$exec_output"
 	return 0
     }
-
 }
 
 proc build_lib {test libname objs dynsymexp} {
-- 
cgit v1.1