From 4d696a5c686730d75623d7e41805e42ce5fcc60c Mon Sep 17 00:00:00 2001 From: Simon Marchi Date: Thu, 12 Mar 2020 14:12:36 -0400 Subject: gdb/selftest.m4: ensure $development is set Before commit 3d1e5a43cbe ("gdbsupport/configure.ac: source development.sh"), the GDB build in non-development mode (turn development to false in bfd/development.sh if you want to try) was broken because the gdbsupport configure script didn't source bfd/development.sh to set the development variable. Since the GDB_AC_SELFTEST macro relies on the `development` variable, I propose to modify it such that it errors out if $development does not have an expected value of "true" or "false". This could prevent a future similar problem from happening while refactoring the configure scripts. It would have caught the problem fixed by the patch mentioned earlier. gdb/ChangeLog: * selftest.m4 (GDB_AC_SELFTEST): Error out if $development is not "true" or "false". * configure: Re-generate. gdbserver/ChangeLog: * configure: Re-generate. gdbsupport/ChangeLog: * configure: Re-generate. --- gdbserver/ChangeLog | 4 ++++ gdbserver/configure | 5 +++++ 2 files changed, 9 insertions(+) (limited to 'gdbserver') diff --git a/gdbserver/ChangeLog b/gdbserver/ChangeLog index ef8addb..94e1c04 100644 --- a/gdbserver/ChangeLog +++ b/gdbserver/ChangeLog @@ -1,3 +1,7 @@ +2020-03-12 Simon Marchi + + * configure: Re-generate. + 2020-03-11 Simon Marchi * configure: Re-generate. diff --git a/gdbserver/configure b/gdbserver/configure index 13ac718..b0a2568 100755 --- a/gdbserver/configure +++ b/gdbserver/configure @@ -6083,6 +6083,11 @@ fi # The default value of this option changes depending whether we're on # development mode (in which case it's "true") or not (in which case # it's "false"). + +if test "x$development" != xtrue && test "x$development" != xfalse; then : + as_fn_error $? "Invalid value for \$development, got \"$development\", expecting \"true\" or \"false\"." "$LINENO" 5 +fi + # Check whether --enable-unit-tests was given. if test "${enable_unit_tests+set}" = set; then : enableval=$enable_unit_tests; case "${enableval}" in -- cgit v1.1