From 3fd3d7d29c5ea6ba2dff07fe353bac80fefce363 Mon Sep 17 00:00:00 2001 From: Andrew Cagney Date: Sun, 20 Jan 2002 19:26:50 +0000 Subject: Assume TARGET_BYTE_ORDER_SELECTABLE{,_P} is always true. --- gdb/ChangeLog | 25 ++++++++++++++++++ gdb/arch-utils.c | 56 ++++++++-------------------------------- gdb/config/arc/tm-arc.h | 4 +-- gdb/config/arm/tm-arm.h | 1 - gdb/config/arm/tm-linux.h | 4 --- gdb/config/arm/tm-wince.h | 4 --- gdb/config/mcore/tm-mcore.h | 3 --- gdb/config/mips/tm-wince.h | 1 - gdb/config/powerpc/tm-ppc-eabi.h | 2 -- gdb/config/sh/tm-wince.h | 1 - gdb/config/sparc/tm-sparclet.h | 1 - gdb/config/sparc/tm-sparclite.h | 1 - gdb/doc/ChangeLog | 5 ++++ gdb/doc/gdbint.texinfo | 6 ----- gdb/gdbarch.h | 26 ------------------- gdb/gdbarch.sh | 26 ------------------- gdb/gdbserver/low-sim.c | 4 --- gdb/remote-sim.c | 3 +-- gdb/sparc-tdep.c | 11 ++------ 19 files changed, 46 insertions(+), 138 deletions(-) (limited to 'gdb') diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 1b4ef88..68a6090 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,28 @@ +2002-01-20 Andrew Cagney + + * remote-sim.c (gdbsim_open): Simplify code testing the macro + TARGET_BYTE_ORDER_SELECTABLE_P. Assume the target is always + byte-order selectable. + * sparc-tdep.c (sparc_target_architecture_hook): Ditto. + * arch-utils.c: Ditto. + (set_endian): Ditto. + (set_endian_from_file): Ditto. + * gdbserver/low-sim.c (create_inferior): Ditto. + * gdbarch.sh: Ditto. + * gdbarch.h: Re-generate. + * config/powerpc/tm-ppc-eabi.h (TARGET_BYTE_ORDER_SELECTABLE_P): + * config/sparc/tm-sparclite.h (TARGET_BYTE_ORDER_SELECTABLE): + * config/sparc/tm-sparclet.h (TARGET_BYTE_ORDER_SELECTABLE): + * config/mcore/tm-mcore.h (TARGET_BYTE_ORDER_SELECTABLE_P): + * config/arm/tm-wince.h (TARGET_BYTE_ORDER_SELECTABLE_P): + * config/arm/tm-linux.h (TARGET_BYTE_ORDER_SELECTABLE_P): + * config/arc/tm-arc.h (TARGET_BYTE_ORDER_SELECTABLE): + * config/arm/tm-arm.h (TARGET_BYTE_ORDER_SELECTABLE_P): Delete + macro definition. + * config/mips/tm-wince.h: Remove #undef of macro + TARGET_BYTE_ORDER_SELECTABLE. + * config/sh/tm-wince.h: Ditto. + 2002-01-20 Daniel Jacobowitz * gdbtypes.h (struct cplus_struct_type): Add is_artificial to diff --git a/gdb/arch-utils.c b/gdb/arch-utils.c index b99e62a..ea95cde 100644 --- a/gdb/arch-utils.c +++ b/gdb/arch-utils.c @@ -399,23 +399,6 @@ generic_register_virtual_size (int regnum) /* Functions to manipulate the endianness of the target. */ -#ifdef TARGET_BYTE_ORDER_SELECTABLE -/* compat - Catch old targets that expect a selectable byte-order to - default to BFD_ENDIAN_BIG */ -#ifndef TARGET_BYTE_ORDER_DEFAULT -#define TARGET_BYTE_ORDER_DEFAULT BFD_ENDIAN_BIG -#endif -#endif -#if !TARGET_BYTE_ORDER_SELECTABLE_P -#ifndef TARGET_BYTE_ORDER_DEFAULT -/* compat - Catch old non byte-order selectable targets that do not - define TARGET_BYTE_ORDER_DEFAULT and instead expect - TARGET_BYTE_ORDER to be used as the default. For targets that - defined neither TARGET_BYTE_ORDER nor TARGET_BYTE_ORDER_DEFAULT the - below will get a strange compiler warning. */ -#define TARGET_BYTE_ORDER_DEFAULT TARGET_BYTE_ORDER -#endif -#endif #ifndef TARGET_BYTE_ORDER_DEFAULT #define TARGET_BYTE_ORDER_DEFAULT BFD_ENDIAN_BIG /* arbitrary */ #endif @@ -453,11 +436,7 @@ show_endian (char *args, int from_tty) static void set_endian (char *ignore_args, int from_tty, struct cmd_list_element *c) { - if (!TARGET_BYTE_ORDER_SELECTABLE_P) - { - printf_unfiltered ("Byte order is not selectable."); - } - else if (set_endian_string == endian_auto) + if (set_endian_string == endian_auto) { target_byte_order_auto = 1; } @@ -508,33 +487,20 @@ set_endian (char *ignore_args, int from_tty, struct cmd_list_element *c) static void set_endian_from_file (bfd *abfd) { + int want; if (GDB_MULTI_ARCH) internal_error (__FILE__, __LINE__, "set_endian_from_file: not for multi-arch"); - if (TARGET_BYTE_ORDER_SELECTABLE_P) - { - int want; - - if (bfd_big_endian (abfd)) - want = BFD_ENDIAN_BIG; - else - want = BFD_ENDIAN_LITTLE; - if (TARGET_BYTE_ORDER_AUTO) - target_byte_order = want; - else if (TARGET_BYTE_ORDER != want) - warning ("%s endian file does not match %s endian target.", - want == BFD_ENDIAN_BIG ? "big" : "little", - TARGET_BYTE_ORDER == BFD_ENDIAN_BIG ? "big" : "little"); - } + if (bfd_big_endian (abfd)) + want = BFD_ENDIAN_BIG; else - { - if (bfd_big_endian (abfd) - ? TARGET_BYTE_ORDER != BFD_ENDIAN_BIG - : TARGET_BYTE_ORDER == BFD_ENDIAN_BIG) - warning ("%s endian file does not match %s endian target.", - bfd_big_endian (abfd) ? "big" : "little", - TARGET_BYTE_ORDER == BFD_ENDIAN_BIG ? "big" : "little"); - } + want = BFD_ENDIAN_LITTLE; + if (TARGET_BYTE_ORDER_AUTO) + target_byte_order = want; + else if (TARGET_BYTE_ORDER != want) + warning ("%s endian file does not match %s endian target.", + want == BFD_ENDIAN_BIG ? "big" : "little", + TARGET_BYTE_ORDER == BFD_ENDIAN_BIG ? "big" : "little"); } diff --git a/gdb/config/arc/tm-arc.h b/gdb/config/arc/tm-arc.h index a015843..52ed091 100644 --- a/gdb/config/arc/tm-arc.h +++ b/gdb/config/arc/tm-arc.h @@ -24,8 +24,8 @@ /* Used by arc-tdep.c to set the default cpu type. */ #define DEFAULT_ARC_CPU_TYPE "base" -/* Byte order is selectable. */ -#define TARGET_BYTE_ORDER_SELECTABLE +/* We have IEEE floating point, if we have any float at all. */ +#define IEEE_FLOAT (1) /* Offset from address of function to start of its code. Zero on most machines. */ diff --git a/gdb/config/arm/tm-arm.h b/gdb/config/arm/tm-arm.h index 80fc1f6..cd20548 100644 --- a/gdb/config/arm/tm-arm.h +++ b/gdb/config/arm/tm-arm.h @@ -31,7 +31,6 @@ struct value; /* Target byte order on ARM defaults to selectable, and defaults to little endian. */ -#define TARGET_BYTE_ORDER_SELECTABLE_P 1 #define TARGET_BYTE_ORDER_DEFAULT BFD_ENDIAN_LITTLE /* IEEE format floating point. */ diff --git a/gdb/config/arm/tm-linux.h b/gdb/config/arm/tm-linux.h index 97520e7..51036b6 100644 --- a/gdb/config/arm/tm-linux.h +++ b/gdb/config/arm/tm-linux.h @@ -34,10 +34,6 @@ extern struct link_map_offsets *arm_linux_svr4_fetch_link_map_offsets (void); #define SVR4_FETCH_LINK_MAP_OFFSETS() arm_linux_svr4_fetch_link_map_offsets () -/* Target byte order on ARM Linux is little endian and not selectable. */ -#undef TARGET_BYTE_ORDER_SELECTABLE_P -#define TARGET_BYTE_ORDER_SELECTABLE_P 0 - /* Under ARM Linux the traditional way of performing a breakpoint is to execute a particular software interrupt, rather than use a particular undefined instruction to provoke a trap. Upon exection of the software diff --git a/gdb/config/arm/tm-wince.h b/gdb/config/arm/tm-wince.h index 40e58ba..82f97ad 100644 --- a/gdb/config/arm/tm-wince.h +++ b/gdb/config/arm/tm-wince.h @@ -31,8 +31,4 @@ void wince_software_single_step (unsigned int, int); -/* Target byte order is little endian and not selectable on WinCE. */ -#undef TARGET_BYTE_ORDER_SELECTABLE_P -#define TARGET_BYTE_ORDER_SELECTABLE_P 0 - #endif /* TM_WINCE_H */ diff --git a/gdb/config/mcore/tm-mcore.h b/gdb/config/mcore/tm-mcore.h index 22631c0..80e438e 100644 --- a/gdb/config/mcore/tm-mcore.h +++ b/gdb/config/mcore/tm-mcore.h @@ -155,9 +155,6 @@ extern void mcore_virtual_frame_pointer (CORE_ADDR, int *, LONGEST *); #define TARGET_VIRTUAL_FRAME_POINTER(PC, REGP, OFFP) \ mcore_virtual_frame_pointer ((PC), (REGP), (OFFP)) -/* MCore can be bi-endian. */ -#define TARGET_BYTE_ORDER_SELECTABLE_P 1 - /* For PE, gcc will tell us what th real type of arguments are when it promotes arguments. */ #define BELIEVE_PCC_PROMOTION 1 diff --git a/gdb/config/mips/tm-wince.h b/gdb/config/mips/tm-wince.h index 737ccc6..f96c4fa 100644 --- a/gdb/config/mips/tm-wince.h +++ b/gdb/config/mips/tm-wince.h @@ -29,7 +29,6 @@ #define SOFTWARE_SINGLE_STEP(sig, bp_p) wince_software_single_step (sig, bp_p) void wince_software_single_step (unsigned int, int); -#undef TARGET_BYTE_ORDER_SELECTABLE #define TARGET_BYTE_ORDER BFD_ENDIAN_LITTLE #endif /* TM_WINCE_H */ diff --git a/gdb/config/powerpc/tm-ppc-eabi.h b/gdb/config/powerpc/tm-ppc-eabi.h index 8830504..92e4127 100644 --- a/gdb/config/powerpc/tm-ppc-eabi.h +++ b/gdb/config/powerpc/tm-ppc-eabi.h @@ -39,8 +39,6 @@ /* Say that we're using ELF, not XCOFF. */ #define ELF_OBJECT_FORMAT 1 -#define TARGET_BYTE_ORDER_SELECTABLE_P 1 - /* The value of symbols of type N_SO and N_FUN maybe null when it shouldn't be. */ #define SOFUN_ADDRESS_MAYBE_MISSING diff --git a/gdb/config/sh/tm-wince.h b/gdb/config/sh/tm-wince.h index ddebbd2..e939808 100644 --- a/gdb/config/sh/tm-wince.h +++ b/gdb/config/sh/tm-wince.h @@ -28,7 +28,6 @@ #undef SOFTWARE_SINGLE_STEP #define SOFTWARE_SINGLE_STEP(sig, bp_p) wince_software_single_step (sig, bp_p) void wince_software_single_step (unsigned int, int); -#undef TARGET_BYTE_ORDER_SELECTABLE #define TARGET_BYTE_ORDER BFD_ENDIAN_LITTLE #endif /* TM_WINCE_H */ diff --git a/gdb/config/sparc/tm-sparclet.h b/gdb/config/sparc/tm-sparclet.h index 5382718..cc52d5a 100644 --- a/gdb/config/sparc/tm-sparclet.h +++ b/gdb/config/sparc/tm-sparclet.h @@ -49,7 +49,6 @@ enum { /* overrides of tm-sparc.h */ #undef TARGET_BYTE_ORDER -#define TARGET_BYTE_ORDER_SELECTABLE /* Sequence of bytes for breakpoint instruction (ta 1). */ #undef BREAKPOINT diff --git a/gdb/config/sparc/tm-sparclite.h b/gdb/config/sparc/tm-sparclite.h index 71723f2..8fafe5e 100644 --- a/gdb/config/sparc/tm-sparclite.h +++ b/gdb/config/sparc/tm-sparclite.h @@ -45,7 +45,6 @@ enum { /* overrides of tm-sparc.h */ #undef TARGET_BYTE_ORDER -#define TARGET_BYTE_ORDER_SELECTABLE /* Select the sparclite disassembler. Slightly different instruction set from the V8 sparc. */ diff --git a/gdb/doc/ChangeLog b/gdb/doc/ChangeLog index f94c102..2d8bc4b 100644 --- a/gdb/doc/ChangeLog +++ b/gdb/doc/ChangeLog @@ -1,5 +1,10 @@ 2002-01-20 Andrew Cagney + * gdbint.texinfo (Target Architecture Definition): Delete + description of TARGET_BYTE_ORDER_SELECTABLE_P. + +2002-01-20 Andrew Cagney + * gdbint.texinfo (Host Definition): Revise. xm-xyz.h and xyz.mh are no longer needed. (Porting GDB): Add maintainer note about configure.host. diff --git a/gdb/doc/gdbint.texinfo b/gdb/doc/gdbint.texinfo index 6605a76..3139cf0 100644 --- a/gdb/doc/gdbint.texinfo +++ b/gdb/doc/gdbint.texinfo @@ -3480,12 +3480,6 @@ The ordering of bytes in the target. This must be either @code{BFD_ENDIAN_BIG} or @code{BFD_ENDIAN_LITTLE}. This macro replaces @code{TARGET_BYTE_ORDER} which is deprecated. -@item TARGET_BYTE_ORDER_SELECTABLE_P -@findex TARGET_BYTE_ORDER_SELECTABLE_P -Non-zero if the target has both @code{BIG_ENDIAN} and -@code{BFD_ENDIAN_LITTLE} variants. This macro replaces -@code{TARGET_BYTE_ORDER_SELECTABLE} which is deprecated. - @item TARGET_CHAR_BIT @findex TARGET_CHAR_BIT Number of bits in a char; defaults to 8. diff --git a/gdb/gdbarch.h b/gdb/gdbarch.h index 1c09fac..d3b6170 100644 --- a/gdb/gdbarch.h +++ b/gdb/gdbarch.h @@ -2392,33 +2392,7 @@ extern void register_gdbarch_swap (void *data, unsigned long size, gdbarch_swap_ /* The target-system-dependent byte order is dynamic */ -/* TARGET_BYTE_ORDER_SELECTABLE_P determines if the target endianness - is selectable at runtime. The user can use the ``set endian'' - command to change it. TARGET_BYTE_ORDER_AUTO is nonzero when - target_byte_order should be auto-detected (from the program image - say). */ - -#if GDB_MULTI_ARCH -/* Multi-arch GDB is always bi-endian. */ -#define TARGET_BYTE_ORDER_SELECTABLE_P 1 -#endif - -#ifndef TARGET_BYTE_ORDER_SELECTABLE_P -/* compat - Catch old targets that define TARGET_BYTE_ORDER_SLECTABLE - when they should have defined TARGET_BYTE_ORDER_SELECTABLE_P 1 */ -#ifdef TARGET_BYTE_ORDER_SELECTABLE -#define TARGET_BYTE_ORDER_SELECTABLE_P 1 -#else -#define TARGET_BYTE_ORDER_SELECTABLE_P 0 -#endif -#endif - extern int target_byte_order; -#ifdef TARGET_BYTE_ORDER_SELECTABLE -/* compat - Catch old targets that define TARGET_BYTE_ORDER_SELECTABLE - and expect defs.h to re-define TARGET_BYTE_ORDER. */ -#undef TARGET_BYTE_ORDER -#endif #ifndef TARGET_BYTE_ORDER #define TARGET_BYTE_ORDER (target_byte_order + 0) #endif diff --git a/gdb/gdbarch.sh b/gdb/gdbarch.sh index d6046ec..23998d5 100755 --- a/gdb/gdbarch.sh +++ b/gdb/gdbarch.sh @@ -1056,33 +1056,7 @@ extern void register_gdbarch_swap (void *data, unsigned long size, gdbarch_swap_ /* The target-system-dependent byte order is dynamic */ -/* TARGET_BYTE_ORDER_SELECTABLE_P determines if the target endianness - is selectable at runtime. The user can use the \`\`set endian'' - command to change it. TARGET_BYTE_ORDER_AUTO is nonzero when - target_byte_order should be auto-detected (from the program image - say). */ - -#if GDB_MULTI_ARCH -/* Multi-arch GDB is always bi-endian. */ -#define TARGET_BYTE_ORDER_SELECTABLE_P 1 -#endif - -#ifndef TARGET_BYTE_ORDER_SELECTABLE_P -/* compat - Catch old targets that define TARGET_BYTE_ORDER_SLECTABLE - when they should have defined TARGET_BYTE_ORDER_SELECTABLE_P 1 */ -#ifdef TARGET_BYTE_ORDER_SELECTABLE -#define TARGET_BYTE_ORDER_SELECTABLE_P 1 -#else -#define TARGET_BYTE_ORDER_SELECTABLE_P 0 -#endif -#endif - extern int target_byte_order; -#ifdef TARGET_BYTE_ORDER_SELECTABLE -/* compat - Catch old targets that define TARGET_BYTE_ORDER_SELECTABLE - and expect defs.h to re-define TARGET_BYTE_ORDER. */ -#undef TARGET_BYTE_ORDER -#endif #ifndef TARGET_BYTE_ORDER #define TARGET_BYTE_ORDER (target_byte_order + 0) #endif diff --git a/gdb/gdbserver/low-sim.c b/gdb/gdbserver/low-sim.c index e98b6c5..86a0406 100644 --- a/gdb/gdbserver/low-sim.c +++ b/gdb/gdbserver/low-sim.c @@ -88,10 +88,8 @@ create_inferior (char *program, char **argv) { bfd *abfd; int pid = 0; -#ifdef TARGET_BYTE_ORDER_SELECTABLE char **new_argv; int nargs; -#endif abfd = bfd_openr (program, 0); if (!abfd) @@ -108,7 +106,6 @@ create_inferior (char *program, char **argv) exit (1); } -#ifdef TARGET_BYTE_ORDER_SELECTABLE /* Add "-E big" or "-E little" to the argument list depending on the endianness of the program to be loaded. */ for (nargs = 0; argv[nargs] != NULL; nargs++) /* count the args */ @@ -120,7 +117,6 @@ create_inferior (char *program, char **argv) new_argv[nargs + 1] = bfd_big_endian (abfd) ? "big" : "little"; new_argv[nargs + 2] = NULL; argv = new_argv; -#endif /* Create an instance of the simulator. */ default_callback.init (&default_callback); diff --git a/gdb/remote-sim.c b/gdb/remote-sim.c index dbae403..1d037c8 100644 --- a/gdb/remote-sim.c +++ b/gdb/remote-sim.c @@ -474,8 +474,7 @@ gdbsim_open (char *args, int from_tty) strcpy (arg_buf, "gdbsim"); /* 7 */ /* Specify the byte order for the target when it is both selectable and explicitly specified by the user (not auto detected). */ - if (TARGET_BYTE_ORDER_SELECTABLE_P - && !TARGET_BYTE_ORDER_AUTO) + if (!TARGET_BYTE_ORDER_AUTO) { switch (TARGET_BYTE_ORDER) { diff --git a/gdb/sparc-tdep.c b/gdb/sparc-tdep.c index a32841c..1b7954b 100644 --- a/gdb/sparc-tdep.c +++ b/gdb/sparc-tdep.c @@ -2200,15 +2200,8 @@ sparc_target_architecture_hook (const bfd_arch_info_type *ap) if (ap->mach == bfd_mach_sparc_sparclite_le) { - if (TARGET_BYTE_ORDER_SELECTABLE_P) - { - target_byte_order = BFD_ENDIAN_LITTLE; - bi_endian = 1; - } - else - { - warning ("This GDB does not support little endian sparclite."); - } + target_byte_order = BFD_ENDIAN_LITTLE; + bi_endian = 1; } else bi_endian = 0; -- cgit v1.1