From 73937e031a946d29ddfff632d478c904fed8d6ff Mon Sep 17 00:00:00 2001 From: Andrew Cagney Date: Thu, 14 Nov 2002 00:25:05 +0000 Subject: 2002-11-13 Andrew Cagney * regcache.h (deprecated_read_register_bytes): Rename read_register_bytes. (deprecated_write_register_bytes): Rename write_register_bytes. * alpha-tdep.c, arm-tdep.c, cris-tdep.c, d10v-tdep.c: Update. * dwarf2cfi.c, frv-tdep.c, hppa-tdep.c, ia64-tdep.c: Update. * m68k-tdep.c, mcore-tdep.c, mips-tdep.c, mn10300-tdep.c: Update. * ns32k-tdep.c, regcache.c, remote-sds.c, remote-vx.c: Update. * remote.c, rs6000-tdep.c, s390-tdep.c, sh-tdep.c: Update. * sparc-tdep.c, v850-tdep.c, vax-tdep.c, x86-64-tdep.c: Update. * xstormy16-tdep.c, z8k-tdep.c, config/nm-gnu.h: Update. * config/nm-m3.h, config/h8500/tm-h8500.h: Update. * config/i386/nm-ptx4.h, config/i386/nm-symmetry.h: Update. * config/m32r/tm-m32r.h, config/m68k/nm-sun3.h: Update. * config/m68k/tm-delta68.h, config/m68k/tm-linux.h: Update. * config/mn10200/tm-mn10200.h, config/pa/tm-hppa64.h: Update. * config/sparc/nm-nbsd.h, config/sparc/nm-sun4os4.h: Update. * config/sparc/nm-sun4sol2.h, config/sparc/tm-sparclet.h: Update. 2002-11-13 Andrew Cagney * mi-main.c (mi_cmd_data_write_register_values): Use deprecated_write_register_bytes instead of write_register_bytes. --- gdb/regcache.c | 32 ++++++++++++++++---------------- 1 file changed, 16 insertions(+), 16 deletions(-) (limited to 'gdb/regcache.c') diff --git a/gdb/regcache.c b/gdb/regcache.c index 0e5dae6..9afafad 100644 --- a/gdb/regcache.c +++ b/gdb/regcache.c @@ -598,29 +598,29 @@ deprecated_registers_fetched (void) Fetching all real regs NEVER accounts for pseudo-regs. */ } -/* read_register_bytes and write_register_bytes are generally a *BAD* - idea. They are inefficient because they need to check for partial - updates, which can only be done by scanning through all of the - registers and seeing if the bytes that are being read/written fall - inside of an invalid register. [The main reason this is necessary - is that register sizes can vary, so a simple index won't suffice.] - It is far better to call read_register_gen and write_register_gen - if you want to get at the raw register contents, as it only takes a - regnum as an argument, and therefore can't do a partial register - update. +/* deprecated_read_register_bytes and deprecated_write_register_bytes + are generally a *BAD* idea. They are inefficient because they need + to check for partial updates, which can only be done by scanning + through all of the registers and seeing if the bytes that are being + read/written fall inside of an invalid register. [The main reason + this is necessary is that register sizes can vary, so a simple + index won't suffice.] It is far better to call read_register_gen + and write_register_gen if you want to get at the raw register + contents, as it only takes a regnum as an argument, and therefore + can't do a partial register update. Prior to the recent fixes to check for partial updates, both read - and write_register_bytes always checked to see if any registers - were stale, and then called target_fetch_registers (-1) to update - the whole set. This caused really slowed things down for remote - targets. */ + and deprecated_write_register_bytes always checked to see if any + registers were stale, and then called target_fetch_registers (-1) + to update the whole set. This caused really slowed things down for + remote targets. */ /* Copy INLEN bytes of consecutive data from registers starting with the INREGBYTE'th byte of register data into memory at MYADDR. */ void -read_register_bytes (int in_start, char *in_buf, int in_len) +deprecated_read_register_bytes (int in_start, char *in_buf, int in_len) { int in_end = in_start + in_len; int regnum; @@ -960,7 +960,7 @@ regcache_cooked_write (struct regcache *regcache, int regnum, const void *buf) into registers starting with the MYREGSTART'th byte of register data. */ void -write_register_bytes (int myregstart, char *myaddr, int inlen) +deprecated_write_register_bytes (int myregstart, char *myaddr, int inlen) { int myregend = myregstart + inlen; int regnum; -- cgit v1.1