From 64cc34d87089ff24b43e0a8760be132b7afa6f34 Mon Sep 17 00:00:00 2001 From: Weimin Pan Date: Tue, 29 May 2018 22:01:34 +0000 Subject: Removing lookup_minimal_symbol_and_objfile Function lookup_minimal_symbol_and_objfile iterates on all objfiles and calls lookup_minimal_symbol for each of them, effectively searching in all objfiles. lookup_bound_minimal_symbol calls lookup_minimal_symbol with NULL, which also effectively searches all objfiles. AFAIK, they do exactly the same thing, so we can get rid of one (and lookup_minimal_symbol_and_objfile happens to be the most inefficient because it ends up n^2 on the number of objfiles). Tested in both aarch64-linux-gnu and amd64-linux-gnu. No regressions. --- gdb/printcmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'gdb/printcmd.c') diff --git a/gdb/printcmd.c b/gdb/printcmd.c index 0dfea34..d0037ae 100644 --- a/gdb/printcmd.c +++ b/gdb/printcmd.c @@ -1549,7 +1549,7 @@ info_address_command (const char *exp, int from_tty) { struct bound_minimal_symbol msym; - msym = lookup_minimal_symbol_and_objfile (SYMBOL_LINKAGE_NAME (sym)); + msym = lookup_bound_minimal_symbol (SYMBOL_LINKAGE_NAME (sym)); if (msym.minsym == NULL) printf_filtered ("unresolved"); else -- cgit v1.1