From 190852c8ac75cb62a737c58edfadfb0e1fcef78a Mon Sep 17 00:00:00 2001 From: Joel Brobecker Date: Thu, 10 May 2018 10:27:13 -0500 Subject: gdbserver/Windows: crash during connection establishment phase On Windows, starting a new process with GDBserver seems to work, in the sense that the program does get started, and GDBserver confirms that it is listening for GDB to connect. However, as soon as GDB establishes the connection with GDBserver, and starts discussing with it, GDBserver crashes, with a SEGV. This SEGV occurs in remote-utils.c::prepare_resume_reply... | regp = current_target_desc ()->expedite_regs; | [...] | while (*regp) ... because, in our case, REGP is NULL. This patches fixes the issues by adding a parameter to init_target_desc, in order to make sure that we always provide the list of registers when we initialize a target description. gdb/ChangeLog: PR server/23158: * regformats/regdat.sh: Adjust script, following the addition of the new expedite_regs parameter to init_target_desc. gdb/gdbserver/ChangeLog: PR server/23158: * tdesc.h (init_target_desc) : New parameter. * tdesc.c (init_target_desc) : New parameter. Use it to set the expedite_regs field in the given tdesc. * x86-tdesc.h: New file. * linux-aarch64-tdesc.c (aarch64_linux_read_description): Adjust following the addition of the new expedite_regs parameter to init_target_desc. * linux-tic6x-low.c (tic6x_read_description): Likewise. * linux-x86-tdesc.c: #include "x86-tdesc.h". (i386_linux_read_description, amd64_linux_read_description): Adjust following the addition of the new expedite_regs parameter to init_target_desc. * lynx-i386-low.c: #include "x86-tdesc.h". (lynx_i386_arch_setup): Adjust following the addition of the new expedite_regs parameter to init_target_desc. * nto-x86-low.c: #include "x86-tdesc.h". (nto_x86_arch_setup): Adjust following the addition of the new expedite_regs parameter to init_target_desc. * win32-i386-low.c: #include "x86-tdesc.h". (i386_arch_setup): Adjust following the addition of the new expedite_regs parameter to init_target_desc. --- gdb/gdbserver/linux-x86-tdesc.c | 15 +++------------ 1 file changed, 3 insertions(+), 12 deletions(-) (limited to 'gdb/gdbserver/linux-x86-tdesc.c') diff --git a/gdb/gdbserver/linux-x86-tdesc.c b/gdb/gdbserver/linux-x86-tdesc.c index 47b8476..358659b 100644 --- a/gdb/gdbserver/linux-x86-tdesc.c +++ b/gdb/gdbserver/linux-x86-tdesc.c @@ -25,6 +25,7 @@ #ifdef __x86_64__ #include "arch/amd64.h" #endif +#include "x86-tdesc.h" /* Return the right x86_linux_tdesc index for a given XCR0. Return X86_TDESC_LAST if can't find a match. */ @@ -88,12 +89,7 @@ i386_linux_read_description (uint64_t xcr0) { *tdesc = i386_create_target_description (xcr0, true); - init_target_desc (*tdesc); - -#ifndef IN_PROCESS_AGENT - static const char *expedite_regs_i386[] = { "ebp", "esp", "eip", NULL }; - (*tdesc)->expedite_regs = expedite_regs_i386; -#endif + init_target_desc (*tdesc, i386_expedite_regs); } return *tdesc;; @@ -124,12 +120,7 @@ amd64_linux_read_description (uint64_t xcr0, bool is_x32) { *tdesc = amd64_create_target_description (xcr0, is_x32, true); - init_target_desc (*tdesc); - -#ifndef IN_PROCESS_AGENT - static const char *expedite_regs_amd64[] = { "rbp", "rsp", "rip", NULL }; - (*tdesc)->expedite_regs = expedite_regs_amd64; -#endif + init_target_desc (*tdesc, amd64_expedite_regs); } return *tdesc; } -- cgit v1.1