From aff689d36d66dd45a59008f3778d3d22e3cfcb9b Mon Sep 17 00:00:00 2001 From: Tom Tromey Date: Sat, 21 Apr 2018 12:00:29 -0600 Subject: Add -Wduplicated-cond This adds -Wduplicated-cond to warnings.m4. This caught one bug. I tried adding -Wduplicated-branches as well, but it results in some spurious failures from code like this in cgen.h: #define CGEN_ATTR_TYPE(n) \ struct { unsigned int bool_; \ CGEN_ATTR_VALUE_TYPE nonbool[(n) ? (n) : 1]; } This will trigger a warning if passed n==1, which seems like a perfectly valid thing to do; and there were other issues like this as well. ChangeLog 2018-05-07 Tom Tromey * configure: Rebuild. * warning.m4 (AM_GDB_WARNINGS): Add -Wduplicated-cond. gdbserver/ChangeLog 2018-05-07 Tom Tromey * configure: Rebuild. --- gdb/gdbserver/configure | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'gdb/gdbserver/configure') diff --git a/gdb/gdbserver/configure b/gdb/gdbserver/configure index 919ed31..ac61ba3 100755 --- a/gdb/gdbserver/configure +++ b/gdb/gdbserver/configure @@ -7174,7 +7174,8 @@ build_warnings="-Wall -Wpointer-arith \ -Wno-mismatched-tags \ -Wno-error=deprecated-register \ -Wsuggest-override \ --Wimplicit-fallthrough" +-Wimplicit-fallthrough \ +-Wduplicated-cond" case "${host}" in *-*-mingw32*) -- cgit v1.1