From 451953fa440aa0ade02b652159155fae689483a3 Mon Sep 17 00:00:00 2001 From: Pedro Alves Date: Fri, 11 May 2018 19:10:14 +0100 Subject: Eliminate the 'the_core_target' global (previously called 'core_target', but since renamed because 'core_target' is the name of the target_ops class now.) This eliminates the "the_core_target" global, as preparation for being able to have more than one core loaded. When we get there, we will instantiate one core_target object per core instead. Essentially, this replaces the reference to the_core_target in core_file_command by a reference to core_bfd, which is per program_space. Currently, core_file_command calls 'the_core_target->detach()' even if the core target is not open and pushed on the target stack. If it is indeed not open, then the practical effect is that core_target::detach() prints "No core file now.". That is preserved by printing that directly from within core_file_command if not debugging a core. gdb/ChangeLog: 2018-05-11 Pedro Alves * corefile.c (core_file_command): Move to corelow.c. * corelow.c (the_core_target): Delete. (core_file_command): Moved from corefile.c. Check exec_bfd instead of the_core_target. Use target_detach instead of calling into the_core_target directly. (maybe_say_no_core_file_now): New. (core_target::detach): Use it. (_initialize_corelow): Remove references to the_core_target. * gdbcore.h (the_core_target): Delete. --- gdb/gdbcore.h | 4 ---- 1 file changed, 4 deletions(-) (limited to 'gdb/gdbcore.h') diff --git a/gdb/gdbcore.h b/gdb/gdbcore.h index d06ccc3..04a4b47 100644 --- a/gdb/gdbcore.h +++ b/gdb/gdbcore.h @@ -135,10 +135,6 @@ extern void specify_exec_file_hook (void (*hook) (const char *filename)); #define core_bfd (current_program_space->cbfd) -/* corelow.c target. It is never NULL after GDB initialization. */ - -extern struct target_ops *the_core_target; - /* Whether to open exec and core files read-only or read-write. */ extern int write_files; -- cgit v1.1