From 1831a9f9d3346dbf61202d2aba6935f0093487dd Mon Sep 17 00:00:00 2001 From: Tom Tromey Date: Sun, 29 Apr 2018 21:02:19 -0600 Subject: Remove new_bfd_ref For gdb_bfd_ref_ptr, gdb already had a convenience function like the new gdb_ref_ptr::new_reference -- called new_bfd_ref. This patch removes it in favor of the new common function. While doing this I also noticed that the comment for gdb_bfd_open was incorrect (in a way related to reference counting), so this patch updates the comment as well. ChangeLog 2018-04-30 Tom Tromey * symfile-mem.c (symbol_file_add_from_memory): Use new_reference. * gdb_bfd.h (new_bfd_ref): Remove. (gdb_bfd_open): Update comment. * gdb_bfd.c (gdb_bfd_open, gdb_bfd_fopen, gdb_bfd_openr) (gdb_bfd_openw, gdb_bfd_openr_iovec, gdb_bfd_record_inclusion) (gdb_bfd_fdopenr): Use new_reference. * exec.c (exec_file_attach): Use new_reference. --- gdb/gdb_bfd.h | 25 +++++++------------------ 1 file changed, 7 insertions(+), 18 deletions(-) (limited to 'gdb/gdb_bfd.h') diff --git a/gdb/gdb_bfd.h b/gdb/gdb_bfd.h index 2e4ac2c..85300b9 100644 --- a/gdb/gdb_bfd.h +++ b/gdb/gdb_bfd.h @@ -68,27 +68,16 @@ struct gdb_bfd_ref_policy /* A gdb::ref_ptr that has been specialized for BFD objects. */ typedef gdb::ref_ptr gdb_bfd_ref_ptr; -/* A helper function that calls gdb_bfd_ref and returns a - gdb_bfd_ref_ptr. */ - -static inline gdb_bfd_ref_ptr -new_bfd_ref (struct bfd *abfd) -{ - gdb_bfd_ref (abfd); - return gdb_bfd_ref_ptr (abfd); -} - /* Open a read-only (FOPEN_RB) BFD given arguments like bfd_fopen. If NAME starts with TARGET_SYSROOT_PREFIX then the BFD will be opened using target fileio operations if necessary. Returns NULL - on error. On success, returns a new reference to the BFD, which - must be freed with gdb_bfd_unref. BFDs returned by this call are - shared among all callers opening the same file. If FD is not -1, - then after this call it is owned by BFD. If the BFD was not - accessed using target fileio operations then the filename - associated with the BFD and accessible with bfd_get_filename will - not be exactly NAME but rather NAME with TARGET_SYSROOT_PREFIX - stripped. */ + on error. On success, returns a new reference to the BFD. BFDs + returned by this call are shared among all callers opening the same + file. If FD is not -1, then after this call it is owned by BFD. + If the BFD was not accessed using target fileio operations then the + filename associated with the BFD and accessible with + bfd_get_filename will not be exactly NAME but rather NAME with + TARGET_SYSROOT_PREFIX stripped. */ gdb_bfd_ref_ptr gdb_bfd_open (const char *name, const char *target, int fd); -- cgit v1.1