From 6e53356b77887974e554ae07f9d76b83cd211700 Mon Sep 17 00:00:00 2001 From: Tom Tromey Date: Sun, 3 Dec 2023 12:10:14 -0700 Subject: Do not write the index cache from an index The new .debug_names reader will work by creating a cooked index from .debug_names. This patch updates cooked_index::maybe_write_index to avoid writing the index in this case. However, in order to do this in a clean way, the readers are changed so that a nullptr result from index_for_writing means "cannot be done", and then the error message is moved into write_dwarf_index (where it historically lived). --- gdb/dwarf2/index-write.c | 2 ++ 1 file changed, 2 insertions(+) (limited to 'gdb/dwarf2/index-write.c') diff --git a/gdb/dwarf2/index-write.c b/gdb/dwarf2/index-write.c index 2decee6..5cd550e 100644 --- a/gdb/dwarf2/index-write.c +++ b/gdb/dwarf2/index-write.c @@ -1629,6 +1629,8 @@ write_dwarf_index (dwarf2_per_bfd *per_bfd, const char *dir, if (per_bfd->index_table == nullptr) error (_("No debugging symbols")); cooked_index *table = per_bfd->index_table->index_for_writing (); + if (table == nullptr) + error (_("Cannot use an index to create the index")); if (per_bfd->types.size () > 1) error (_("Cannot make an index when the file has multiple .debug_types sections")); -- cgit v1.1