From 0cac9354bfb07a5cf53d70dbefaa35c6afa7da0a Mon Sep 17 00:00:00 2001 From: Simon Marchi Date: Mon, 13 Jan 2020 18:12:08 -0500 Subject: gdb: use gdb::byte_vector instead of std::vector in core_target::get_core_register_section Since the data held by the `contents` variable is arbitrary binary data, it should have gdb_byte elements, not char elements. Also, using gdb::byte_vector is preferable, since it doesn't unnecessarily zero-initialize the values. Instead of adding a cast in the call to m_core_vec->core_read_registers, I have changed core_read_registers' argument to be a gdb_byte* instead of a char*. gdb/ChangeLog: * gdbcore.h (struct core_fns) : Change core_reg_sect type to gdb_byte *. * arm-nbsd-nat.c (fetch_elfcore_registers): Likewise. * cris-tdep.c (fetch_core_registers): Likewise. * corelow.c (core_target::get_core_register_section): Change type of `contents` to gdb::byte_vector. --- gdb/cris-tdep.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'gdb/cris-tdep.c') diff --git a/gdb/cris-tdep.c b/gdb/cris-tdep.c index 22b4db9..6885d23 100644 --- a/gdb/cris-tdep.c +++ b/gdb/cris-tdep.c @@ -3793,7 +3793,7 @@ cris_supply_gregset (struct regcache *regcache, cris_elf_gregset_t *gregsetp) static void fetch_core_registers (struct regcache *regcache, - char *core_reg_sect, unsigned core_reg_size, + gdb_byte *core_reg_sect, unsigned core_reg_size, int which, CORE_ADDR reg_addr) { cris_elf_gregset_t gregset; -- cgit v1.1