From 1a0670f37442b7ae904932b347353046126b990c Mon Sep 17 00:00:00 2001 From: Alan Modra Date: Wed, 5 Oct 2016 18:17:02 +1030 Subject: -Wimplicit-fallthrough warning fixes Comment changes. bfd/ * coff-h8300.c: Spell fall through comments consistently. * coffgen.c: Likewise. * elf32-hppa.c: Likewise. * elf32-ppc.c: Likewise. * elf32-score.c: Likewise. * elf32-score7.c: Likewise. * elf64-ppc.c: Likewise. * elfxx-aarch64.c: Likewise. * elfxx-mips.c: Likewise. * cpu-ns32k.c: Add missing fall through comments. * elf-m10300.c: Likewise. * elf32-arm.c: Likewise. * elf32-avr.c: Likewise. * elf32-bfin.c: Likewise. * elf32-frv.c: Likewise. * elf32-i386.c: Likewise. * elf32-microblaze.c: Likewise. * elf32-nds32.c: Likewise. * elf32-ppc.c: Likewise. * elf32-rl78.c: Likewise. * elf32-rx.c: Likewise. * elf32-s390.c: Likewise. * elf32-sh.c: Likewise. * elf32-tic6x.c: Likewise. * elf64-ia64-vms.c: Likewise. * elf64-ppc.c: Likewise. * elf64-s390.c: Likewise. * elf64-x86-64.c: Likewise. * elflink.c: Likewise. * elfnn-aarch64.c: Likewise. * elfnn-ia64.c: Likewise. * ieee.c: Likewise. * oasys.c: Likewise. * pdp11.c: Likewise. * srec.c: Likewise. * versados.c: Likewise. opcodes/ * aarch64-opc.c: Spell fall through comments consistently. * i386-dis.c: Likewise. * aarch64-dis.c: Add missing fall through comments. * aarch64-opc.c: Likewise. * arc-dis.c: Likewise. * arm-dis.c: Likewise. * i386-dis.c: Likewise. * m68k-dis.c: Likewise. * mep-asm.c: Likewise. * ns32k-dis.c: Likewise. * sh-dis.c: Likewise. * tic4x-dis.c: Likewise. * tic6x-dis.c: Likewise. * vax-dis.c: Likewise. binutils/ * dlltool.c: Spell fall through comments consistently. * objcopy.c: Likewise. * readelf.c: Likewise. * dwarf.c: Add missing fall through comments. * elfcomm.c: Likewise. * sysinfo.y: Likewise. * readelf.c: Likewise. Also remove extraneous comments. gas/ * app.c: Add missing fall through comments. * dw2gencfi.c: Likewise. * expr.c: Likewise. * config/tc-alpha.c: Likewise. * config/tc-arc.c: Likewise. * config/tc-arm.c: Likewise. * config/tc-cr16.c: Likewise. * config/tc-crx.c: Likewise. * config/tc-dlx.c: Likewise. * config/tc-h8300.c: Likewise. * config/tc-hppa.c: Likewise. * config/tc-i370.c: Likewise. * config/tc-i386.c: Likewise. * config/tc-i960.c: Likewise. * config/tc-ia64.c: Likewise. * config/tc-m68hc11.c: Likewise. * config/tc-m68k.c: Likewise. * config/tc-mep.c: Likewise. * config/tc-metag.c: Likewise. * config/tc-microblaze.c: Likewise. * config/tc-mips.c: Likewise. * config/tc-ns32k.c: Likewise. * config/tc-rx.c: Likewise. * config/tc-score.c: Likewise. * config/tc-score7.c: Likewise. * config/tc-sh.c: Likewise. * config/tc-tic4x.c: Likewise. * config/tc-vax.c: Likewise. * config/tc-xstormy16.c: Likewise. * config/tc-z80.c: Likewise. * config/tc-z8k.c: Likewise. * config/obj-elf.c: Likewise. * config/tc-i386.c: Likewise. * depend.c: Spell fall through comments consistently. * config/tc-arm.c: Likewise. * config/tc-d10v.c: Likewise. * config/tc-i960.c: Likewise. * config/tc-ia64.c: Likewise. * config/tc-m68k.c: Likewise. * config/tc-mcore.c: Likewise. * config/tc-mep.c: Likewise. * config/tc-ns32k.c: Likewise. * config/tc-visium.c: Likewise. * config/tc-xstormy16.c: Likewise. * config/tc-z8k.c: Likewise. gprof/ * gprof.c: Add missing fall through comments. ld/ * lexsup.c: Spell fall through comments consistently and add missing fall through comments. --- bfd/ChangeLog | 39 +++++++++++++++++++++++++++++++++++++++ bfd/coff-h8300.c | 4 +--- bfd/coffgen.c | 4 ++-- bfd/cpu-ns32k.c | 4 ++++ bfd/elf-m10300.c | 1 + bfd/elf32-arm.c | 1 + bfd/elf32-avr.c | 1 + bfd/elf32-bfin.c | 1 + bfd/elf32-frv.c | 1 + bfd/elf32-hppa.c | 2 +- bfd/elf32-i386.c | 1 + bfd/elf32-microblaze.c | 3 +++ bfd/elf32-nds32.c | 3 +++ bfd/elf32-ppc.c | 17 +++++++++-------- bfd/elf32-rl78.c | 1 + bfd/elf32-rx.c | 4 ++++ bfd/elf32-s390.c | 2 ++ bfd/elf32-score.c | 5 +++-- bfd/elf32-score7.c | 5 +++-- bfd/elf32-sh.c | 1 + bfd/elf32-tic6x.c | 1 + bfd/elf64-ia64-vms.c | 1 + bfd/elf64-ppc.c | 21 +++++++++++---------- bfd/elf64-s390.c | 2 ++ bfd/elf64-x86-64.c | 2 ++ bfd/elflink.c | 1 + bfd/elfnn-aarch64.c | 2 ++ bfd/elfnn-ia64.c | 1 + bfd/elfxx-aarch64.c | 2 +- bfd/elfxx-mips.c | 3 ++- bfd/ieee.c | 14 ++++++++++++++ bfd/oasys.c | 1 + bfd/pdp11.c | 1 + bfd/srec.c | 2 ++ bfd/versados.c | 1 + 35 files changed, 125 insertions(+), 30 deletions(-) (limited to 'bfd') diff --git a/bfd/ChangeLog b/bfd/ChangeLog index 11381ea..a276240 100644 --- a/bfd/ChangeLog +++ b/bfd/ChangeLog @@ -1,5 +1,44 @@ 2016-10-06 Alan Modra + * coff-h8300.c: Spell fall through comments consistently. + * coffgen.c: Likewise. + * elf32-hppa.c: Likewise. + * elf32-ppc.c: Likewise. + * elf32-score.c: Likewise. + * elf32-score7.c: Likewise. + * elf64-ppc.c: Likewise. + * elfxx-aarch64.c: Likewise. + * elfxx-mips.c: Likewise. + * cpu-ns32k.c: Add missing fall through comments. + * elf-m10300.c: Likewise. + * elf32-arm.c: Likewise. + * elf32-avr.c: Likewise. + * elf32-bfin.c: Likewise. + * elf32-frv.c: Likewise. + * elf32-i386.c: Likewise. + * elf32-microblaze.c: Likewise. + * elf32-nds32.c: Likewise. + * elf32-ppc.c: Likewise. + * elf32-rl78.c: Likewise. + * elf32-rx.c: Likewise. + * elf32-s390.c: Likewise. + * elf32-sh.c: Likewise. + * elf32-tic6x.c: Likewise. + * elf64-ia64-vms.c: Likewise. + * elf64-ppc.c: Likewise. + * elf64-s390.c: Likewise. + * elf64-x86-64.c: Likewise. + * elflink.c: Likewise. + * elfnn-aarch64.c: Likewise. + * elfnn-ia64.c: Likewise. + * ieee.c: Likewise. + * oasys.c: Likewise. + * pdp11.c: Likewise. + * srec.c: Likewise. + * versados.c: Likewise. + +2016-10-06 Alan Modra + * coffcode.h (coff_slurp_symbol_table): Revert accidental commit made 2015-01-08. * elf32-nds32.c (nds32_elf_grok_psinfo): Add missing break. diff --git a/bfd/coff-h8300.c b/bfd/coff-h8300.c index 3e4722c..a687708 100644 --- a/bfd/coff-h8300.c +++ b/bfd/coff-h8300.c @@ -579,9 +579,7 @@ h8300_reloc16_estimate (bfd *abfd, asection *input_section, arelent *reloc, /* Done with this reloc. */ break; } - - /* FALLTHROUGH and try to turn the 24-/32-bit reloc into a 16-bit - reloc. */ + /* Fall through. */ /* This is a 24-/32-bit absolute address in a mov insn, which can become an 16-bit absolute address if it's in the right range. */ diff --git a/bfd/coffgen.c b/bfd/coffgen.c index 216102e..1dc77a4 100644 --- a/bfd/coffgen.c +++ b/bfd/coffgen.c @@ -2134,7 +2134,7 @@ coff_print_symbol (bfd *abfd, auxp->u.auxent.x_scn.x_comdat); break; } - /* Otherwise fall through. */ + /* Fall through. */ case C_EXT: case C_AIX_WEAKEXT: if (ISFCN (combined->u.syment.n_type)) @@ -2154,7 +2154,7 @@ coff_print_symbol (bfd *abfd, llnos, next); break; } - /* Otherwise fall through. */ + /* Fall through. */ default: fprintf (file, "AUX lnno %d size 0x%x tagndx %ld", auxp->u.auxent.x_sym.x_misc.x_lnsz.x_lnno, diff --git a/bfd/cpu-ns32k.c b/bfd/cpu-ns32k.c index b11318c..98f22e1 100644 --- a/bfd/cpu-ns32k.c +++ b/bfd/cpu-ns32k.c @@ -106,8 +106,10 @@ _bfd_ns32k_get_immediate (bfd_byte *buffer, int size) case 4: value = (value << 8) | (*buffer++ & 0xff); value = (value << 8) | (*buffer++ & 0xff); + /* Fall through. */ case 2: value = (value << 8) | (*buffer++ & 0xff); + /* Fall through. */ case 1: value = (value << 8) | (*buffer++ & 0xff); break; @@ -126,8 +128,10 @@ _bfd_ns32k_put_immediate (bfd_vma value, bfd_byte *buffer, int size) case 4: *buffer-- = (value & 0xff); value >>= 8; *buffer-- = (value & 0xff); value >>= 8; + /* Fall through. */ case 2: *buffer-- = (value & 0xff); value >>= 8; + /* Fall through. */ case 1: *buffer-- = (value & 0xff); value >>= 8; } diff --git a/bfd/elf-m10300.c b/bfd/elf-m10300.c index 9b44c0a..25f1668 100644 --- a/bfd/elf-m10300.c +++ b/bfd/elf-m10300.c @@ -1470,6 +1470,7 @@ mn10300_elf_final_link_relocate (reloc_howto_type *howto, && h != NULL && ! SYMBOL_REFERENCES_LOCAL (info, h)) return bfd_reloc_dangerous; + /* Fall through. */ case R_MN10300_GOT32: /* Issue 2052223: Taking the address of a protected function in a shared library diff --git a/bfd/elf32-arm.c b/bfd/elf32-arm.c index cafe1a2..8dcc6d8 100644 --- a/bfd/elf32-arm.c +++ b/bfd/elf32-arm.c @@ -10041,6 +10041,7 @@ elf32_arm_final_link_relocate (reloc_howto_type * howto, case R_ARM_ABS12: if (!globals->vxworks_p) return elf32_arm_abs12_reloc (input_bfd, hit_data, value + addend); + /* Fall through. */ case R_ARM_PC24: case R_ARM_ABS32: diff --git a/bfd/elf32-avr.c b/bfd/elf32-avr.c index ecea3d7..ef88f02 100644 --- a/bfd/elf32-avr.c +++ b/bfd/elf32-avr.c @@ -2682,6 +2682,7 @@ elf32_avr_relax_section (bfd *abfd, } } } + /* Fall through. */ default: { diff --git a/bfd/elf32-bfin.c b/bfd/elf32-bfin.c index 6a3dabc..0a00803 100644 --- a/bfd/elf32-bfin.c +++ b/bfd/elf32-bfin.c @@ -2695,6 +2695,7 @@ bfinfdpic_relocate_section (bfd * output_bfd, case R_BFIN_BYTE4_DATA: if (! IS_FDPIC (output_bfd)) goto non_fdpic; + /* Fall through. */ case R_BFIN_GOT17M4: case R_BFIN_GOTHI: diff --git a/bfd/elf32-frv.c b/bfd/elf32-frv.c index 5d8d330..80f6959 100644 --- a/bfd/elf32-frv.c +++ b/bfd/elf32-frv.c @@ -2775,6 +2775,7 @@ elf32_frv_relocate_section (bfd *output_bfd ATTRIBUTE_UNUSED, case R_FRV_32: if (! IS_FDPIC (output_bfd)) goto non_fdpic; + /* Fall through. */ case R_FRV_GOT12: case R_FRV_GOTHI: diff --git a/bfd/elf32-hppa.c b/bfd/elf32-hppa.c index 439e0d8..8d9638f 100644 --- a/bfd/elf32-hppa.c +++ b/bfd/elf32-hppa.c @@ -3951,7 +3951,7 @@ elf32_hppa_relocate_section (bfd *output_bfd, } plabel = 1; } - /* Fall through and possibly emit a dynamic relocation. */ + /* Fall through. */ case R_PARISC_DIR17F: case R_PARISC_DIR17R: diff --git a/bfd/elf32-i386.c b/bfd/elf32-i386.c index 14a99ba..c6f2fd6 100644 --- a/bfd/elf32-i386.c +++ b/bfd/elf32-i386.c @@ -1947,6 +1947,7 @@ elf_i386_check_relocs (bfd *abfd, case R_386_GOTOFF: eh->gotoff_ref = 1; + /* Fall through. */ case R_386_32: case R_386_PC32: case R_386_PLT32: diff --git a/bfd/elf32-microblaze.c b/bfd/elf32-microblaze.c index cc4b3cc..778c6f0 100644 --- a/bfd/elf32-microblaze.c +++ b/bfd/elf32-microblaze.c @@ -1197,6 +1197,7 @@ microblaze_elf_relocate_section (bfd *output_bfd, goto dogot; case (int) R_MICROBLAZE_TLSLD: tls_type = (TLS_TLS | TLS_LD); + /* Fall through. */ dogot: case (int) R_MICROBLAZE_GOT_64: { @@ -2401,8 +2402,10 @@ microblaze_elf_check_relocs (bfd * abfd, goto dogottls; case R_MICROBLAZE_TLSLD: tls_type |= (TLS_TLS | TLS_LD); + /* Fall through. */ dogottls: sec->has_tls_reloc = 1; + /* Fall through. */ case R_MICROBLAZE_GOT_64: if (htab->sgot == NULL) { diff --git a/bfd/elf32-nds32.c b/bfd/elf32-nds32.c index 0f2d6da..ac09e87 100644 --- a/bfd/elf32-nds32.c +++ b/bfd/elf32-nds32.c @@ -11229,6 +11229,7 @@ nds32_elf_relax_letlsls (struct bfd_link_info *link_info, bfd *abfd, success = 1; break; } + /* Fall through. */ case (N32_OP6_MEM << 8) | N32_MEM_LH: case (N32_OP6_MEM << 8) | N32_MEM_SH: case (N32_OP6_MEM << 8) | N32_MEM_LHS: @@ -11243,6 +11244,7 @@ nds32_elf_relax_letlsls (struct bfd_link_info *link_info, bfd *abfd, success = 1; break; } + /* Fall through. */ case (N32_OP6_MEM << 8) | N32_MEM_LW: case (N32_OP6_MEM << 8) | N32_MEM_SW: /* The range is +/-64k. */ @@ -11256,6 +11258,7 @@ nds32_elf_relax_letlsls (struct bfd_link_info *link_info, bfd *abfd, success = 1; break; } + /* Fall through. */ default: break; } diff --git a/bfd/elf32-ppc.c b/bfd/elf32-ppc.c index f631b27..627bff5 100644 --- a/bfd/elf32-ppc.c +++ b/bfd/elf32-ppc.c @@ -4160,7 +4160,7 @@ ppc_elf_check_relocs (bfd *abfd, tls_type = TLS_TLS | TLS_DTPREL; dogottls: sec->has_tls_reloc = 1; - /* Fall thru */ + /* Fall through. */ /* GOT16 relocations */ case R_PPC_GOT16: @@ -4232,7 +4232,7 @@ ppc_elf_check_relocs (bfd *abfd, case R_PPC_SDAREL16: htab->sdata[0].sym->ref_regular = 1; - /* Fall thru */ + /* Fall through. */ case R_PPC_VLE_SDAREL_LO16A: case R_PPC_VLE_SDAREL_LO16D: @@ -5167,7 +5167,7 @@ ppc_elf_gc_sweep_hook (bfd *abfd, case R_PPC_REL32: if (h == NULL || h == htab->elf.hgot) break; - /* Fall thru */ + /* Fall through. */ case R_PPC_ADDR32: case R_PPC_ADDR24: @@ -5182,6 +5182,7 @@ ppc_elf_gc_sweep_hook (bfd *abfd, case R_PPC_UADDR16: if (bfd_link_pic (info)) break; + /* Fall through. */ case R_PPC_PLT32: case R_PPC_PLTREL24: @@ -5409,7 +5410,7 @@ ppc_elf_tls_optimize (bfd *obfd ATTRIBUTE_UNUSED, case R_PPC_GOT_TLSLD16: case R_PPC_GOT_TLSLD16_LO: expecting_tls_get_addr = 1; - /* Fall thru */ + /* Fall through. */ case R_PPC_GOT_TLSLD16_HI: case R_PPC_GOT_TLSLD16_HA: @@ -5427,7 +5428,7 @@ ppc_elf_tls_optimize (bfd *obfd ATTRIBUTE_UNUSED, case R_PPC_GOT_TLSGD16: case R_PPC_GOT_TLSGD16_LO: expecting_tls_get_addr = 1; - /* Fall thru */ + /* Fall through. */ case R_PPC_GOT_TLSGD16_HI: case R_PPC_GOT_TLSGD16_HA: @@ -8154,7 +8155,7 @@ ppc_elf_relocate_section (bfd *output_bfd, case R_PPC_ADDR14_BRTAKEN: case R_PPC_REL14_BRTAKEN: branch_bit = BRANCH_PREDICT_BIT; - /* Fall thru */ + /* Fall through. */ /* Branch not taken prediction relocations. */ case R_PPC_ADDR14_BRNTAKEN: @@ -8978,7 +8979,7 @@ ppc_elf_relocate_section (bfd *output_bfd, + htab->plt->output_offset + ent->plt.offset); } - /* Fall thru */ + /* Fall through. */ case R_PPC_RELAX: { @@ -9480,7 +9481,7 @@ ppc_elf_relocate_section (bfd *output_bfd, alone (it will be set to zero elsewhere in the link). */ if (sec == NULL) break; - /* Fall thru */ + /* Fall through. */ case R_PPC_PLT16_HA: case R_PPC_GOT16_HA: diff --git a/bfd/elf32-rl78.c b/bfd/elf32-rl78.c index 3ba426f..6cfed33 100644 --- a/bfd/elf32-rl78.c +++ b/bfd/elf32-rl78.c @@ -1958,6 +1958,7 @@ rl78_offset_for_reloc (bfd * abfd, default: reloc_computes_value: symval = rl78_compute_complex_reloc (r_type, symval, input_section); + /* Fall through. */ case R_RL78_DIR32: case R_RL78_DIR24S: case R_RL78_DIR16: diff --git a/bfd/elf32-rx.c b/bfd/elf32-rx.c index 49556d2..7d5dc73 100644 --- a/bfd/elf32-rx.c +++ b/bfd/elf32-rx.c @@ -704,6 +704,7 @@ rx_elf_relocate_section case R_RX_RH_8_NEG: WARN_REDHAT ("RX_RH_8_NEG"); relocation = - relocation; + /* Fall through. */ case R_RX_DIR8S_PCREL: UNSAFE_FOR_PID; RANGE (-128, 127); @@ -725,6 +726,7 @@ rx_elf_relocate_section case R_RX_RH_16_NEG: WARN_REDHAT ("RX_RH_16_NEG"); relocation = - relocation; + /* Fall through. */ case R_RX_DIR16S_PCREL: UNSAFE_FOR_PID; RANGE (-32768, 32767); @@ -809,6 +811,7 @@ rx_elf_relocate_section UNSAFE_FOR_PID; WARN_REDHAT ("RX_RH_24_NEG"); relocation = - relocation; + /* Fall through. */ case R_RX_DIR24S_PCREL: RANGE (-0x800000, 0x7fffff); #if RX_OPCODE_BIG_ENDIAN @@ -1232,6 +1235,7 @@ rx_elf_relocate_section case R_RX_ABS8S: UNSAFE_FOR_PID; + /* Fall through. */ case R_RX_ABS8S_PCREL: RX_STACK_POP (relocation); RANGE (-128, 127); diff --git a/bfd/elf32-s390.c b/bfd/elf32-s390.c index 921268f..7285ad6 100644 --- a/bfd/elf32-s390.c +++ b/bfd/elf32-s390.c @@ -1124,6 +1124,7 @@ elf_s390_check_relocs (bfd *abfd, case R_390_GOTOFF32: if (h == NULL || !s390_is_ifunc_symbol_p (h) || !h->def_regular) break; + /* Fall through. */ case R_390_PLT12DBL: case R_390_PLT16DBL: @@ -2802,6 +2803,7 @@ elf_s390_relocate_section (bfd *output_bfd, + h ->plt.offset); goto do_relocation; } + /* Fall through. */ case R_390_8: case R_390_16: diff --git a/bfd/elf32-score.c b/bfd/elf32-score.c index ec88a42..9f84c4e 100644 --- a/bfd/elf32-score.c +++ b/bfd/elf32-score.c @@ -2746,7 +2746,7 @@ s3_bfd_score_elf_relocate_section (bfd *output_bfd, default: msg = _("internal error: unknown error"); - /* fall through */ + /* Fall through. */ common_error: (*info->callbacks->warning) (info, msg, name, input_bfd, @@ -3655,7 +3655,8 @@ s3_bfd_score_elf_finish_dynamic_sections (bfd *output_bfd, } /* In case if we don't have global got symbols we default to setting DT_SCORE_GOTSYM to the same value as - DT_SCORE_SYMTABNO, so we just fall through. */ + DT_SCORE_SYMTABNO. */ + /* Fall through. */ case DT_SCORE_SYMTABNO: name = ".dynsym"; diff --git a/bfd/elf32-score7.c b/bfd/elf32-score7.c index 2c6da80..3aad1c7 100644 --- a/bfd/elf32-score7.c +++ b/bfd/elf32-score7.c @@ -2551,7 +2551,7 @@ s7_bfd_score_elf_relocate_section (bfd *output_bfd, default: msg = _("internal error: unknown error"); - /* fall through */ + /* Fall through. */ common_error: (*info->callbacks->warning) (info, msg, name, input_bfd, @@ -3466,7 +3466,8 @@ s7_bfd_score_elf_finish_dynamic_sections (bfd *output_bfd, } /* In case if we don't have global got symbols we default to setting DT_SCORE_GOTSYM to the same value as - DT_SCORE_SYMTABNO, so we just fall through. */ + DT_SCORE_SYMTABNO. */ + /* Fall through. */ case DT_SCORE_SYMTABNO: name = ".dynsym"; diff --git a/bfd/elf32-sh.c b/bfd/elf32-sh.c index d43ac54..7f108fb 100644 --- a/bfd/elf32-sh.c +++ b/bfd/elf32-sh.c @@ -5881,6 +5881,7 @@ sh_elf_check_relocs (bfd *abfd, struct bfd_link_info *info, asection *sec, /* This may require an rofixup. */ if (!htab->fdpic_p) break; + /* Fall through. */ case R_SH_GOTPLT32: case R_SH_GOT32: case R_SH_GOT20: diff --git a/bfd/elf32-tic6x.c b/bfd/elf32-tic6x.c index c70b169..d2dddbf 100644 --- a/bfd/elf32-tic6x.c +++ b/bfd/elf32-tic6x.c @@ -2365,6 +2365,7 @@ elf32_tic6x_relocate_section (bfd *output_bfd, goto done_reloc; } } + /* Fall through. */ case R_C6000_PCR_S12: case R_C6000_PCR_S10: diff --git a/bfd/elf64-ia64-vms.c b/bfd/elf64-ia64-vms.c index 6f6d5e3..a64e8db 100644 --- a/bfd/elf64-ia64-vms.c +++ b/bfd/elf64-ia64-vms.c @@ -3958,6 +3958,7 @@ elf64_ia64_relocate_section (bfd *output_bfd, rel->r_offset, input_section->size); break; } + /* Fall through. */ default: (*info->callbacks->reloc_overflow) (info, &h->root, diff --git a/bfd/elf64-ppc.c b/bfd/elf64-ppc.c index 2a9ea1e..3264ecf 100644 --- a/bfd/elf64-ppc.c +++ b/bfd/elf64-ppc.c @@ -5471,7 +5471,7 @@ ppc64_elf_check_relocs (bfd *abfd, struct bfd_link_info *info, tls_type = TLS_TLS | TLS_DTPREL; dogottls: sec->has_tls_reloc = 1; - /* Fall thru */ + /* Fall through */ case R_PPC64_GOT16: case R_PPC64_GOT16_DS: @@ -5619,6 +5619,7 @@ ppc64_elf_check_relocs (bfd *abfd, struct bfd_link_info *info, case R_PPC64_TOC16_DS: htab->do_multi_toc = 1; ppc64_elf_tdata (abfd)->has_small_toc_reloc = 1; + /* Fall through. */ case R_PPC64_TOC16_LO: case R_PPC64_TOC16_HI: case R_PPC64_TOC16_HA: @@ -8524,7 +8525,7 @@ ppc64_elf_tls_optimize (struct bfd_link_info *info) case R_PPC64_GOT_TLSLD16_LO: expecting_tls_get_addr = 1; found_tls_get_addr_arg = 1; - /* Fall thru */ + /* Fall through. */ case R_PPC64_GOT_TLSLD16_HI: case R_PPC64_GOT_TLSLD16_HA: @@ -8544,7 +8545,7 @@ ppc64_elf_tls_optimize (struct bfd_link_info *info) case R_PPC64_GOT_TLSGD16_LO: expecting_tls_get_addr = 1; found_tls_get_addr_arg = 1; - /* Fall thru */ + /* Fall through. */ case R_PPC64_GOT_TLSGD16_HI: case R_PPC64_GOT_TLSGD16_HA: @@ -8575,7 +8576,7 @@ ppc64_elf_tls_optimize (struct bfd_link_info *info) case R_PPC64_TLSGD: case R_PPC64_TLSLD: found_tls_get_addr_arg = 1; - /* Fall thru */ + /* Fall through. */ case R_PPC64_TLS: case R_PPC64_TOC16: @@ -9268,7 +9269,7 @@ ppc64_elf_edit_toc (struct bfd_link_info *info) } if ((opc & (0x3f << 2)) == (58u << 2)) break; - /* Fall thru */ + /* Fall through. */ default: /* Wrong sort of reloc, or not a ld. We may @@ -14073,18 +14074,18 @@ ppc64_elf_relocate_section (bfd *output_bfd, case R_PPC64_ADDR14_BRTAKEN: case R_PPC64_REL14_BRTAKEN: insn = 0x01 << 21; /* 'y' or 't' bit, lowest bit of BO field. */ - /* Fall thru. */ + /* Fall through. */ /* Branch not taken prediction relocations. */ case R_PPC64_ADDR14_BRNTAKEN: case R_PPC64_REL14_BRNTAKEN: insn |= bfd_get_32 (output_bfd, contents + rel->r_offset) & ~(0x01 << 21); - /* Fall thru. */ + /* Fall through. */ case R_PPC64_REL14: max_br_offset = 1 << 15; - /* Fall thru. */ + /* Fall through. */ case R_PPC64_REL24: /* Calls to functions with a different TOC, such as calls to @@ -14730,7 +14731,7 @@ ppc64_elf_relocate_section (bfd *output_bfd, case R_PPC64_DTPREL64: if (htab->elf.tls_sec != NULL) addend -= htab->elf.tls_sec->vma + DTP_OFFSET; - /* Fall thru */ + /* Fall through. */ /* Relocations that may need to be propagated if this is a dynamic object. */ @@ -15073,7 +15074,7 @@ ppc64_elf_relocate_section (bfd *output_bfd, alone (it will be set to zero elsewhere in the link). */ if (sec == NULL) break; - /* Fall thru */ + /* Fall through. */ case R_PPC64_GOT16_HA: case R_PPC64_PLTGOT16_HA: diff --git a/bfd/elf64-s390.c b/bfd/elf64-s390.c index 431d06c..f9057e3 100644 --- a/bfd/elf64-s390.c +++ b/bfd/elf64-s390.c @@ -1052,6 +1052,7 @@ elf_s390_check_relocs (bfd *abfd, case R_390_GOTOFF64: if (h == NULL || !s390_is_ifunc_symbol_p (h) || !h->def_regular) break; + /* Fall through. */ case R_390_PLT12DBL: case R_390_PLT16DBL: @@ -2758,6 +2759,7 @@ elf_s390_relocate_section (bfd *output_bfd, + h->plt.offset); goto do_relocation; } + /* Fall through. */ case R_390_8: case R_390_16: diff --git a/bfd/elf64-x86-64.c b/bfd/elf64-x86-64.c index 3cb5c80..2a372a6 100644 --- a/bfd/elf64-x86-64.c +++ b/bfd/elf64-x86-64.c @@ -2327,6 +2327,7 @@ elf_x86_64_check_relocs (bfd *abfd, struct bfd_link_info *info, goto error_return; } } + /* Fall through. */ case R_X86_64_32S: case R_X86_64_PC64: @@ -2525,6 +2526,7 @@ elf_x86_64_check_relocs (bfd *abfd, struct bfd_link_info *info, case R_X86_64_32: if (!ABI_64_P (abfd)) goto pointer; + /* Fall through. */ case R_X86_64_8: case R_X86_64_16: case R_X86_64_32S: diff --git a/bfd/elflink.c b/bfd/elflink.c index d7207ff..1591682 100644 --- a/bfd/elflink.c +++ b/bfd/elflink.c @@ -7940,6 +7940,7 @@ eval_symbol (bfd_vma *result, case 'S': symbol_is_section = TRUE; + /* Fall through. */ case 's': ++sym; symlen = strtol (sym, (char **) symp, 10); diff --git a/bfd/elfnn-aarch64.c b/bfd/elfnn-aarch64.c index b23db29..56b0943 100644 --- a/bfd/elfnn-aarch64.c +++ b/bfd/elfnn-aarch64.c @@ -5312,6 +5312,7 @@ elfNN_aarch64_final_link_relocate (reloc_howto_type *howto, bfd_set_error (bfd_error_bad_value); return FALSE; } + /* Fall through. */ case BFD_RELOC_AARCH64_16: #if ARCH_SIZE == 64 @@ -7323,6 +7324,7 @@ elfNN_aarch64_check_relocs (bfd *abfd, struct bfd_link_info *info, bfd_set_error (bfd_error_bad_value); return FALSE; } + /* Fall through. */ case BFD_RELOC_AARCH64_ADR_HI21_NC_PCREL: case BFD_RELOC_AARCH64_ADR_HI21_PCREL: diff --git a/bfd/elfnn-ia64.c b/bfd/elfnn-ia64.c index 0654091..a9a01fe 100644 --- a/bfd/elfnn-ia64.c +++ b/bfd/elfnn-ia64.c @@ -4485,6 +4485,7 @@ missing_tls_sec: rel->r_offset, input_section->size); break; } + /* Fall through. */ default: (*info->callbacks->reloc_overflow) (info, &h->root, diff --git a/bfd/elfxx-aarch64.c b/bfd/elfxx-aarch64.c index c861170..bdfb394 100644 --- a/bfd/elfxx-aarch64.c +++ b/bfd/elfxx-aarch64.c @@ -319,7 +319,7 @@ _bfd_aarch64_elf_put_addend (bfd *abfd, /* Force use of MOVZ. */ contents = reencode_movzn_to_movz (contents); } - /* fall through */ + /* Fall through. */ /* Group relocations to create a 16, 32, 48 or 64 bit unsigned data or abs address inline. */ diff --git a/bfd/elfxx-mips.c b/bfd/elfxx-mips.c index c1eeb71..65f1ee4 100644 --- a/bfd/elfxx-mips.c +++ b/bfd/elfxx-mips.c @@ -11645,7 +11645,8 @@ _bfd_mips_elf_finish_dynamic_sections (bfd *output_bfd, } /* In case if we don't have global got symbols we default to setting DT_MIPS_GOTSYM to the same value as - DT_MIPS_SYMTABNO, so we just fall through. */ + DT_MIPS_SYMTABNO. */ + /* Fall through. */ case DT_MIPS_SYMTABNO: name = ".dynsym"; diff --git a/bfd/ieee.c b/bfd/ieee.c index 2bcf58d..1893aee 100644 --- a/bfd/ieee.c +++ b/bfd/ieee.c @@ -2597,10 +2597,13 @@ write_int (int value) { case 4: OUT (value >> 24); + /* Fall through. */ case 3: OUT (value >> 16); + /* Fall through. */ case 2: OUT (value >> 8); + /* Fall through. */ case 1: OUT (value); } @@ -2753,15 +2756,19 @@ drop_int (struct output_buffer_struct *buf) case 0x84: ch = THIS (); NEXT (); + /* Fall through. */ case 0x83: ch = THIS (); NEXT (); + /* Fall through. */ case 0x82: ch = THIS (); NEXT (); + /* Fall through. */ case 0x81: ch = THIS (); NEXT (); + /* Fall through. */ case 0x80: break; } @@ -2791,18 +2798,22 @@ copy_int (void) ch = THIS (); NEXT (); OUT (ch); + /* Fall through. */ case 0x83: ch = THIS (); NEXT (); OUT (ch); + /* Fall through. */ case 0x82: ch = THIS (); NEXT (); OUT (ch); + /* Fall through. */ case 0x81: ch = THIS (); NEXT (); OUT (ch); + /* Fall through. */ case 0x80: break; } @@ -2833,12 +2844,15 @@ copy_till_end (void) case 0x84: OUT (THIS ()); NEXT (); + /* Fall through. */ case 0x83: OUT (THIS ()); NEXT (); + /* Fall through. */ case 0x82: OUT (THIS ()); NEXT (); + /* Fall through. */ case 0x81: OUT (THIS ()); NEXT (); diff --git a/bfd/oasys.c b/bfd/oasys.c index cbc3578..5560d38 100644 --- a/bfd/oasys.c +++ b/bfd/oasys.c @@ -612,6 +612,7 @@ oasys_object_p (bfd *abfd) break; case oasys_record_is_data_enum: oasys->first_data_record = bfd_tell (abfd) - record.header.length; + /* Fall through. */ case oasys_record_is_debug_enum: case oasys_record_is_module_enum: case oasys_record_is_named_section_enum: diff --git a/bfd/pdp11.c b/bfd/pdp11.c index 7daf52d..089c917 100644 --- a/bfd/pdp11.c +++ b/bfd/pdp11.c @@ -2985,6 +2985,7 @@ aout_link_write_other_symbol (struct bfd_hash_entry *bh, void *data) case bfd_link_hash_undefweak: type = N_WEAKU; val = 0; + /* Fall through. */ case bfd_link_hash_indirect: case bfd_link_hash_warning: /* FIXME: Ignore these for now. The circumstances under which diff --git a/bfd/srec.c b/bfd/srec.c index a013f9b..3197ec0 100644 --- a/bfd/srec.c +++ b/bfd/srec.c @@ -972,10 +972,12 @@ srec_write_record (bfd *abfd, case 7: TOHEX (dst, (address >> 24), check_sum); dst += 2; + /* Fall through. */ case 8: case 2: TOHEX (dst, (address >> 16), check_sum); dst += 2; + /* Fall through. */ case 9: case 1: case 0: diff --git a/bfd/versados.c b/bfd/versados.c index ed46e3b..cef4b68 100644 --- a/bfd/versados.c +++ b/bfd/versados.c @@ -296,6 +296,7 @@ process_esd (bfd *abfd, struct ext_esd *esd, int pass) break; case ESD_XDEF_IN_ABS: sec = bfd_abs_section_ptr; + /* Fall through. */ case ESD_XDEF_IN_SEC: { int snum = VDATA (abfd)->def_idx++; -- cgit v1.1