From 7fbd5f4e2c143bbe28715608ca00e2e93a7d7fd4 Mon Sep 17 00:00:00 2001 From: Alan Modra Date: Thu, 17 Dec 2020 23:21:11 +1030 Subject: Remove some static buffers Fixes possible overflow of a static buffer for powerpc with translated messages, and on v850 when symbol names are large. * archive.c (_bfd_ar_spacepad, _bfd_ar_sizepad): Use auto buf. * coff-mcore.c (coff_mcore_relocate_section): Likewise. * elf32-ppc.c (ppc_elf_unhandled_reloc): Use asprintf in place of fixed size and possibly too small buf for translated message. * elf64-ppc.c (ppc64_elf_unhandled_reloc): Likewise. * elf32-v850.c (v850_elf_check_relocs): Likewise. * ecoff.c (ecoff_type_to_string): Pass in return string buff rather than using static buffer2. Delete dead code. Remove unnecessary parentheses. (_bfd_ecoff_print_symbol): Pass auto buff to ecoff_type_to_string. * elf32-rx.c (describe_flags): Pass in return string buf rather than using static buf. (rx_elf_merge_private_bfd_data): Pass buf to describe_flags. (rx_elf_print_private_bfd_data): Likewise. * mach-o.c (cpusubtype): Pass in return string buffer rather than using static buffer. (bfd_mach_o_bfd_print_private_bfd_data): Pass buff to cpusubtype. * opncls.c (separate_debug_file_exists): Make buffer an auto var. (bfd_fill_in_gnu_debuglink_section): Likewise. * peXXigen.c (rsrc_resource_name): Pass in return string buffer rather than using static buffer. (rsrc_sort_entries): Pass buff to rsrc_resource_name. * vms-alpha.c (_bfd_vms_write_emh): Pass tbuf to get_vms_time_string. * vms-misc.c (get_vms_time_string): Pass in return string tbuf rather than using static tbuf. * vms.h (get_vms_time_string): Update prototype. --- bfd/vms.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'bfd/vms.h') diff --git a/bfd/vms.h b/bfd/vms.h index 88cf83e..d9726b4 100644 --- a/bfd/vms.h +++ b/bfd/vms.h @@ -111,7 +111,7 @@ extern void _bfd_hexdump (int, unsigned char *, int, int); #endif extern char * vms_get_module_name (const char *, bfd_boolean); -extern unsigned char *get_vms_time_string (void); +extern unsigned char *get_vms_time_string (unsigned char *); extern time_t vms_time_to_time_t (unsigned int hi, unsigned int lo); extern time_t vms_rawtime_to_time_t (unsigned char *); extern void vms_time_t_to_vms_time (time_t ut, unsigned int *hi, unsigned int *lo); -- cgit v1.1