From 04383fd15b3b82d824df9c72e3ade88c43bfb5ac Mon Sep 17 00:00:00 2001 From: Alan Modra Date: Fri, 27 Apr 2018 15:46:40 +0930 Subject: PR23123, PowerPC32 ifunc regression Two of the gcc ifunc tests fail for ppc32, due to my pr22374 fix being a little too enthusiastic in trimming PLT entries. ppc64 doesn't have the same failures because ppc64_elf_check_relocs happens to set needs_plt for any ifunc reloc. PR 23123 PR 22374 * elf32-ppc.c (ppc_elf_adjust_dynamic_symbol): Don't drop plt relocs for ifuncs. * elf64-ppc.c (ppc64_elf_adjust_dynamic_symbol): Comment fixes. --- bfd/elf64-ppc.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'bfd/elf64-ppc.c') diff --git a/bfd/elf64-ppc.c b/bfd/elf64-ppc.c index 9009768..09377d1 100644 --- a/bfd/elf64-ppc.c +++ b/bfd/elf64-ppc.c @@ -7304,8 +7304,8 @@ ppc64_elf_adjust_dynamic_symbol (struct bfd_link_info *info, if (!readonly_dynrelocs (h)) { h->pointer_equality_needed = 0; - /* If we haven't seen a branch reloc then we don't need - a plt entry. */ + /* If we haven't seen a branch reloc and the symbol + isn't an ifunc then we don't need a plt entry. */ if (!h->needs_plt) h->plt.plist = NULL; } @@ -7321,8 +7321,8 @@ ppc64_elf_adjust_dynamic_symbol (struct bfd_link_info *info, else if (!h->needs_plt && !readonly_dynrelocs (h)) { - /* If we haven't seen a branch reloc then we don't need a - plt entry. */ + /* If we haven't seen a branch reloc and the symbol isn't an + ifunc then we don't need a plt entry. */ h->plt.plist = NULL; h->pointer_equality_needed = 0; return TRUE; -- cgit v1.1