From 8847cac2f7ce6ff2c13fa611660c2dfc59c78272 Mon Sep 17 00:00:00 2001 From: Jan Kratochvil Date: Wed, 10 Jun 2015 19:37:19 +0200 Subject: Code cleanup: Use explicit NULL comparison gdb/ChangeLog 2015-06-10 Jan Kratochvil Code cleanup. * solib-target.c (library_list_start_list): Use explicit NULL comparison. --- gdb/ChangeLog | 6 ++++++ gdb/solib-target.c | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 83845f4..5b19052 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,11 @@ 2015-06-10 Jan Kratochvil + Code cleanup. + * solib-target.c (library_list_start_list): Use explicit NULL + comparison. + +2015-06-10 Jan Kratochvil + * solib-target.c (library_list_start_list): Do not dereference variable version in its initialization. Make the VERSION check handle NULL. diff --git a/gdb/solib-target.c b/gdb/solib-target.c index 891e572..f14363a 100644 --- a/gdb/solib-target.c +++ b/gdb/solib-target.c @@ -149,7 +149,7 @@ library_list_start_list (struct gdb_xml_parser *parser, struct gdb_xml_value *version = xml_find_attribute (attributes, "version"); /* #FIXED attribute may be omitted, Expat returns NULL in such case. */ - if (version) + if (version != NULL) { const char *string = version->value; -- cgit v1.1