From 68ae8e2a84993ab77fdc48a61e1875cdc9db740a Mon Sep 17 00:00:00 2001 From: Sam James Date: Sat, 29 Jun 2024 11:07:18 +0100 Subject: ld: pass -g for ld-elf tests The "DWARF parse during linker error" and "Build warn libbar.so" tests require debug information. configure defaults to "-O2 -g" but if overriding *FLAGS when building tests, this might be lost. Explicitly pass -g given these tests require it. Originally reported downstream in Gentoo at https://bugs.gentoo.org/934149. ld/ * testsuite/ld-elf/dwarf.exp: Pass -g for "DWARF parse during linker error". * testsuite/ld-elf/shared.exp: Ditto for "Build warn libbar.so". (cherry picked from commit 17c78a23491ce76fd6d21cdbf2db3c0cf02145e0) --- ld/testsuite/ld-elf/dwarf.exp | 2 +- ld/testsuite/ld-elf/shared.exp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/ld/testsuite/ld-elf/dwarf.exp b/ld/testsuite/ld-elf/dwarf.exp index 6a63269..670551f 100644 --- a/ld/testsuite/ld-elf/dwarf.exp +++ b/ld/testsuite/ld-elf/dwarf.exp @@ -50,7 +50,7 @@ set build_tests { "-s -shared" "-fPIC -g -feliminate-dwarf2-dups" {dwarf1.c} {} "libdwarf1.so"} {"DWARF parse during linker error" - "" "-fno-toplevel-reorder" + "" "-g -fno-toplevel-reorder" {dwarf2a.c dwarf2b.c} {{error_output "dwarf2.err"}} "dwarf2.x"} {"Handle no DWARF information" "" "-g0" diff --git a/ld/testsuite/ld-elf/shared.exp b/ld/testsuite/ld-elf/shared.exp index 277dc7b..d811738 100644 --- a/ld/testsuite/ld-elf/shared.exp +++ b/ld/testsuite/ld-elf/shared.exp @@ -552,7 +552,7 @@ set build_tests { "-shared" "-fPIC" {begin.c end.c} {} "libbar.so"} {"Build warn libbar.so" - "-shared" "-fPIC" + "-shared" "-fPIC -g" {beginwarn.c end.c} {{readelf {-S --wide} libbarw.rd} {warning {^.*beginwarn.c:7:\(.*\): warning: function foo is deprecated\n?$}}} -- cgit v1.1