From 4dda9cc4b03788d1cf0416b39a3ab3780caf27fd Mon Sep 17 00:00:00 2001 From: Tom Tromey Date: Fri, 1 Sep 2023 11:04:58 -0600 Subject: Fix latent bug in ser_windows_send_break The ClearCommBreak documentation says: If the function fails, the return value is zero. ser_windows_send_break inverts this check. This has never been noticed because the caller doesn't check the result. Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30770 --- gdb/ser-mingw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/ser-mingw.c b/gdb/ser-mingw.c index c0aa5d8..806f399 100644 --- a/gdb/ser-mingw.c +++ b/gdb/ser-mingw.c @@ -137,7 +137,7 @@ ser_windows_send_break (struct serial *scb) /* Delay for 250 milliseconds. */ Sleep (250); - if (ClearCommBreak (h)) + if (ClearCommBreak (h) == 0) return -1; return 0; -- cgit v1.1