diff options
-rw-r--r-- | gdb/ChangeLog | 5 | ||||
-rw-r--r-- | gdb/python/py-tui.c | 2 |
2 files changed, 6 insertions, 1 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 4c3de11..1d486c4 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2020-06-05 Andrew Burgess <andrew.burgess@embecosm.com> + + * python/py-tui.c (gdbpy_tui_set_title): Use release, not get, to + avoid use after free. + 2020-06-05 Tom de Vries <tdevries@suse.de> * NEWS: Fix typos. diff --git a/gdb/python/py-tui.c b/gdb/python/py-tui.c index ca88f85..f2c0339 100644 --- a/gdb/python/py-tui.c +++ b/gdb/python/py-tui.c @@ -433,7 +433,7 @@ gdbpy_tui_set_title (PyObject *self, PyObject *newvalue, void *closure) if (value == nullptr) return -1; - win->window->title = value.get (); + win->window->title = value.release (); return 0; } |