diff options
| author | Mike Frysinger <vapier@gentoo.org> | 2021-04-18 21:01:00 -0400 |
|---|---|---|
| committer | Mike Frysinger <vapier@gentoo.org> | 2021-04-18 21:07:25 -0400 |
| commit | 3912a8db685f5e19a883d02d66900cdf10a200f0 (patch) | |
| tree | 07104f4906862d7e7c2e121b728ab16658dd1d98 /sim/cr16/ChangeLog | |
| parent | 9eab4c18bd39c0dc5b3f41892d80c130b0852e35 (diff) | |
| download | fsf-binutils-gdb-3912a8db685f5e19a883d02d66900cdf10a200f0.zip fsf-binutils-gdb-3912a8db685f5e19a883d02d66900cdf10a200f0.tar.gz fsf-binutils-gdb-3912a8db685f5e19a883d02d66900cdf10a200f0.tar.bz2 | |
sim: cr16: fix build warnings
The printf fix is obvious enough, but the hash one is a real bug:
cr16/interp.c: In function 'sim_open':
cr16/interp.c:560:17: error: 'h' may be used uninitialized in this function [-Werror=maybe-uninitialized]
560 | h = h->next;
| ~~^~~~~~~~~
It happens to not cause a problem currently because the first entry in
the generated table that this loop operates matches a codepath where h
is initialized. Then when later entries don't match, the previous value
is pointing at the end of a valid hash table already, and the rest of
the code does nothing.
With this tidied up, we can delete the SIM_AC_OPTION_WARNINGS(no) call
to get the default common behavior where -Werror is enabled.
Diffstat (limited to 'sim/cr16/ChangeLog')
| -rw-r--r-- | sim/cr16/ChangeLog | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/sim/cr16/ChangeLog b/sim/cr16/ChangeLog index 274d89f..38cfe22 100644 --- a/sim/cr16/ChangeLog +++ b/sim/cr16/ChangeLog @@ -1,3 +1,10 @@ +2021-04-18 Mike Frysinger <vapier@gentoo.org> + + * interp.c (sim_open): Use PRIx64 to match mcode type. Skip the + current simop when it doesn't match a known hash table. + * configure.ac (SIM_AC_OPTION_WARNINGS): Delete call. + * configure: Regenerate. + 2021-04-12 Mike Frysinger <vapier@gentoo.org> * interp.c (sim_open): Delete 3rd arg to sim_cpu_alloc_all. |