diff options
| author | Tsukasa OI <research_trasio@irq.a4lg.com> | 2022-10-06 06:43:52 +0000 |
|---|---|---|
| committer | Andrew Burgess <aburgess@redhat.com> | 2022-10-11 15:18:14 +0100 |
| commit | 340aa4f6872ca3c4f7fc4a79671537064d0ca91f (patch) | |
| tree | d8aa6b70aeb4d0fd3856d55132ff925d8cf7270f /sim/configure.ac | |
| parent | 96894c19ad2b91db76b9b606d48c56ad354b4801 (diff) | |
| download | fsf-binutils-gdb-340aa4f6872ca3c4f7fc4a79671537064d0ca91f.zip fsf-binutils-gdb-340aa4f6872ca3c4f7fc4a79671537064d0ca91f.tar.gz fsf-binutils-gdb-340aa4f6872ca3c4f7fc4a79671537064d0ca91f.tar.bz2 | |
sim: Check known getopt definition existence
Clang generates a warning if there is a function declaration/definition
with zero arguments. Such declarations/definitions without a prototype (an
argument list) are deprecated forms of indefinite arguments
("-Wdeprecated-non-prototype"). On the default configuration, it causes a
build failure (unless "--disable-werror" is specified).
include/getopt.h defines some getopt function definitions but one of them
has a form "extern int getopt ();". If this form is selected in
include/getopt.h, Clang generates a warning and the build fails by default.
In really old environments, this getopt definition with no arguments is
necessary (because the definition may change between environments).
However, this definition is now a cause of problems on modern environments.
A good news is, this definition is not always selected (e.g. if used by
binutils/*.c). This is because configuration scripts of binutils, gas,
gprof and ld tries to find known definition of getopt function is used and
defines HAVE_DECL_GETOPT macro. If this macro is defined when getopt.h is
included, a good form of getopt is used and Clang won't generate warnings.
This commit adds a modified portion of ld/configure.ac to find the known
getopt definition. If we could find one (and we *will* in most modern
environments), we don't need to rely on the deprecated definition.
Diffstat (limited to 'sim/configure.ac')
| -rw-r--r-- | sim/configure.ac | 10 |
1 files changed, 10 insertions, 0 deletions
diff --git a/sim/configure.ac b/sim/configure.ac index 66a1020..be0cfdb 100644 --- a/sim/configure.ac +++ b/sim/configure.ac @@ -177,6 +177,16 @@ SIM_AC_OPTION_STDIO SIM_AC_OPTION_TRACE SIM_AC_OPTION_WARNINGS +AC_MSG_CHECKING(for a known getopt prototype in unistd.h) +AC_CACHE_VAL(sim_cv_decl_getopt_unistd_h, +[AC_COMPILE_IFELSE([AC_LANG_PROGRAM([#include <unistd.h>], [extern int getopt (int, char *const*, const char *);])], +sim_cv_decl_getopt_unistd_h=yes, sim_cv_decl_getopt_unistd_h=no)]) +AC_MSG_RESULT($sim_cv_decl_getopt_unistd_h) +if test $sim_cv_decl_getopt_unistd_h = yes; then + AC_DEFINE([HAVE_DECL_GETOPT], 1, + [Is the prototype for getopt in <unistd.h> in the expected format?]) +fi + dnl These are unfortunate. They are conditionally called by other sim macros dnl but always used by common/Make-common.in. So we have to subst here even dnl when the rest of the code is in the respective macros. Once we merge the |