aboutsummaryrefslogtreecommitdiff
path: root/sim/bfin
diff options
context:
space:
mode:
authorNick Clifton <nickc@redhat.com>2015-04-24 15:43:21 +0100
committerNick Clifton <nickc@redhat.com>2015-04-24 15:43:21 +0100
commitde7669bfa507d78f7abfe3d219b5aee9f346235e (patch)
tree52bf26d31dc3846dd1c2f41a03359be3afdc5c7a /sim/bfin
parent63c72d1ae497cdf43db5347464a97164e720b83f (diff)
downloadfsf-binutils-gdb-de7669bfa507d78f7abfe3d219b5aee9f346235e.zip
fsf-binutils-gdb-de7669bfa507d78f7abfe3d219b5aee9f346235e.tar.gz
fsf-binutils-gdb-de7669bfa507d78f7abfe3d219b5aee9f346235e.tar.bz2
Fix typos in sim sources exposed by static analysis.
bfin PR 18273 * bfin-sim.c (decode_dsp32alu_0): Remove spurious check for s == 1. erc32 PR 18273 * exec.c (add32): Fix typo in check for overflow. igen PR 18273 * misc.c (a2i): Fix typos checking for uppercase letters.
Diffstat (limited to 'sim/bfin')
-rw-r--r--sim/bfin/ChangeLog7
-rw-r--r--sim/bfin/bfin-sim.c2
2 files changed, 8 insertions, 1 deletions
diff --git a/sim/bfin/ChangeLog b/sim/bfin/ChangeLog
index 64d20c3..1940edf 100644
--- a/sim/bfin/ChangeLog
+++ b/sim/bfin/ChangeLog
@@ -1,3 +1,10 @@
+2015-04-24 David Binderman <dcb314@hotmail.com>
+ Nick Clifton <nickc@redhat.com>
+
+ PR 18273
+ * bfin-sim.c (decode_dsp32alu_0): Remove spurious check for
+ s == 1.
+
2015-04-18 Mike Frysinger <vapier@gentoo.org>
* sim-main.h (SIM_CPU): Add note to clean this up.
diff --git a/sim/bfin/bfin-sim.c b/sim/bfin/bfin-sim.c
index 364ee29..24b29e7 100644
--- a/sim/bfin/bfin-sim.c
+++ b/sim/bfin/bfin-sim.c
@@ -4318,7 +4318,7 @@ decode_dsp32alu_0 (SIM_CPU *cpu, bu16 iw0, bu16 iw1)
SET_AREG (1, 0);
}
else if ((aop == 0 || aop == 1 || aop == 2) && s == 1 && aopcde == 8
- && x == 0 && s == 1 && HL == 0)
+ && x == 0 && HL == 0)
{
bs40 acc0 = get_extended_acc (cpu, 0);
bs40 acc1 = get_extended_acc (cpu, 1);