diff options
| author | Mark Wielaard <mjw@redhat.com> | 2016-11-04 23:55:01 +0000 |
|---|---|---|
| committer | Mark Wielaard <mark@klomp.org> | 2016-11-18 11:06:18 +0100 |
| commit | 4d17eaece8b31e642acaf4d77fe961ad8e3aaf50 (patch) | |
| tree | dc02d2bd4f420b18fa85514f3aee1ccd69f8c8a5 /libiberty/cplus-dem.c | |
| parent | ef0f5d7cc3b2082c94beffa7c9c1a8acd8eaa427 (diff) | |
| download | fsf-binutils-gdb-4d17eaece8b31e642acaf4d77fe961ad8e3aaf50.zip fsf-binutils-gdb-4d17eaece8b31e642acaf4d77fe961ad8e3aaf50.tar.gz fsf-binutils-gdb-4d17eaece8b31e642acaf4d77fe961ad8e3aaf50.tar.bz2 | |
libiberty: Fix -Wimplicit-fallthrough warnings.
Adjust some comments, add some explicit fall through comments or explicit
returns where necessary to not get implicit-fallthrough warnings.
All fall throughs were deliberate. In one case I added an explicit return
false for clarity instead of falling through a default case (that also
would return false).
libiberty/ChangeLog:
* cplus-dem.c (demangle_signature): Move fall through comment.
(demangle_fund_type): Add fall through comment between 'G' and 'I'.
* hashtab.c (iterative_hash): Add fall through comments.
* regex.c (regex_compile): Add Fall through comment after '+'/'?'.
(byte_re_match_2_internal): Add Fall through comment after jump_n.
Change "Note fall through" to "Fall through".
(common_op_match_null_string_p): Return false after set_number_at
instead of fall through.
Diffstat (limited to 'libiberty/cplus-dem.c')
| -rw-r--r-- | libiberty/cplus-dem.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/libiberty/cplus-dem.c b/libiberty/cplus-dem.c index 7f63397..c955bfb 100644 --- a/libiberty/cplus-dem.c +++ b/libiberty/cplus-dem.c @@ -1657,9 +1657,7 @@ demangle_signature (struct work_stuff *work, (*mangled)++; break; } - else - /* fall through */ - {;} + /* fall through */ default: if (AUTO_DEMANGLING || GNU_DEMANGLING) @@ -4024,6 +4022,7 @@ demangle_fund_type (struct work_stuff *work, success = 0; break; } + /* fall through */ case 'I': (*mangled)++; if (**mangled == '_') |