aboutsummaryrefslogtreecommitdiff
path: root/ld
diff options
context:
space:
mode:
authorH.J. Lu <hjl.tools@gmail.com>2018-07-02 13:08:09 -0700
committerH.J. Lu <hjl.tools@gmail.com>2018-07-02 13:08:09 -0700
commitb638b5d57fafc84a8dc0ff91d7579a3c24aad90c (patch)
treef4663f1aba02dfe318906ed1f925b2c362a78842 /ld
parenteac61af65bcd24a48633da375527eb3f36ab47ed (diff)
downloadfsf-binutils-gdb-b638b5d57fafc84a8dc0ff91d7579a3c24aad90c.zip
fsf-binutils-gdb-b638b5d57fafc84a8dc0ff91d7579a3c24aad90c.tar.gz
fsf-binutils-gdb-b638b5d57fafc84a8dc0ff91d7579a3c24aad90c.tar.bz2
x86-64: Clear the R_X86_64_converted_reloc_bit bit
We need to clear the R_X86_64_converted_reloc_bit bit after setting it to avoid leaking it out by --emit-relocs. bfd/ PR ld/23324 * elf64-x86-64.c (elf_x86_64_relocate_section): Clear the R_X86_64_converted_reloc_bit bit. ld/ PR ld/23324 * testsuite/ld-x86-64/pr23324.s: New file. * testsuite/ld-x86-64/pr23324a.d: Likewise. * testsuite/ld-x86-64/pr23324b.d: Likewise.
Diffstat (limited to 'ld')
-rw-r--r--ld/ChangeLog7
-rw-r--r--ld/testsuite/ld-x86-64/pr23324.s6
-rw-r--r--ld/testsuite/ld-x86-64/pr23324a.d8
-rw-r--r--ld/testsuite/ld-x86-64/pr23324b.d8
-rw-r--r--ld/testsuite/ld-x86-64/x86-64.exp2
5 files changed, 31 insertions, 0 deletions
diff --git a/ld/ChangeLog b/ld/ChangeLog
index 31959a7..afa9ae8 100644
--- a/ld/ChangeLog
+++ b/ld/ChangeLog
@@ -1,3 +1,10 @@
+2018-07-02 H.J. Lu <hongjiu.lu@intel.com>
+
+ PR ld/23324
+ * testsuite/ld-x86-64/pr23324.s: New file.
+ * testsuite/ld-x86-64/pr23324a.d: Likewise.
+ * testsuite/ld-x86-64/pr23324b.d: Likewise.
+
2018-07-02 Thomas Preud'homme <thomas.preudhomme@arm.com>
* arm-dis.c (select_arm_features): Fix typo in heading comment. Allow
diff --git a/ld/testsuite/ld-x86-64/pr23324.s b/ld/testsuite/ld-x86-64/pr23324.s
new file mode 100644
index 0000000..3bad019
--- /dev/null
+++ b/ld/testsuite/ld-x86-64/pr23324.s
@@ -0,0 +1,6 @@
+ .text
+ .globl _start
+ .type _start,@function
+_start:
+ movq _start@GOTPCREL(%rip), %rsi
+ ret
diff --git a/ld/testsuite/ld-x86-64/pr23324a.d b/ld/testsuite/ld-x86-64/pr23324a.d
new file mode 100644
index 0000000..72a4742
--- /dev/null
+++ b/ld/testsuite/ld-x86-64/pr23324a.d
@@ -0,0 +1,8 @@
+#source: pr23324.s
+#as: --64 -mrelax-relocations=yes
+#ld: -q -melf_x86_64 -pie
+#readelf: -r --wide
+
+Relocation section '.rela.text' at offset 0x[0-9a-f]+ contains 1 entry:
+ +Offset +Info +Type +Sym.* Value +Symbol's Name \+ Addend
+[0-9a-f]+ +[0-9a-f]+ +R_X86_64_PC32 +[0-9a-f]+ +_start - 4
diff --git a/ld/testsuite/ld-x86-64/pr23324b.d b/ld/testsuite/ld-x86-64/pr23324b.d
new file mode 100644
index 0000000..ad58d86
--- /dev/null
+++ b/ld/testsuite/ld-x86-64/pr23324b.d
@@ -0,0 +1,8 @@
+#source: pr23324.s
+#as: --x32 -mrelax-relocations=yes
+#ld: -q -melf32_x86_64 -pie
+#readelf: -r --wide
+
+Relocation section '.rela.text' at offset 0x[0-9a-f]+ contains 1 entry:
+ +Offset +Info +Type +Sym.* Value +Symbol's Name \+ Addend
+[0-9a-f]+ +[0-9a-f]+ +R_X86_64_PC32 +[0-9a-f]+ +_start - 4
diff --git a/ld/testsuite/ld-x86-64/x86-64.exp b/ld/testsuite/ld-x86-64/x86-64.exp
index d07054c..e6ec049 100644
--- a/ld/testsuite/ld-x86-64/x86-64.exp
+++ b/ld/testsuite/ld-x86-64/x86-64.exp
@@ -397,6 +397,8 @@ run_dump_test "pr22782a"
run_dump_test "pr22782b"
run_dump_test "pr23189"
run_dump_test "pr23194"
+run_dump_test "pr23324a"
+run_dump_test "pr23324b"
if { ![istarget "x86_64-*-linux*"] && ![istarget "x86_64-*-nacl*"]} {
return