opcodes/arm: use '@' consistently for the comment character

Looking at the ARM disassembler output, every comment seems to start
with a ';' character, so I assumed this was the correct character to
start an assembler comment.

I then spotted a couple of places where there was no ';', but instead,
just a '@' character.  I thought that this was a case of a missing
';', and proposed a patch to add the missing ';' characters.

Turns out I was wrong, '@' is actually the ARM assembler comment
character, while ';' is the statement separator.  Thus this:

    nop    ;@ comment

is two statements, the first is the 'nop' instruction, while the
second contains no instructions, just the '@ comment' comment text.

This:

    nop    @ comment

is a single 'nop' instruction followed by a comment.  And finally,
this:

    nop    ; comment

is two statements, the first contains the 'nop' instruction, while the
second contains the instruction 'comment', which obviously isn't
actually an instruction at all.

Why this matters is that, in the next commit, I would like to add
libopcodes syntax styling support for ARM.

The question then is how should the disassembler style the three cases
above?

As '@' is the actual comment start character then clearly the '@' and
anything after it can be styled as a comment.  But what about ';' in
the second example?  Style as text?  Style as a comment?

And the third example is even harder, what about the 'comment' text?
Style as an instruction mnemonic?  Style as text?  Style as a comment?

I think the only sensible answer is to move the disassembler to use
'@' consistently as its comment character, and remove all the uses of
';'.

Then, in the next commit, it's obvious what to do.

There's obviously a *lot* of tests that get updated by this commit,
the only actual code changes are in opcodes/arm-dis.c.

1 files changed, 14 insertions, 14 deletions

diff --git a/ld/testsuite/ld-arm/ifunc-12.dd b/ld/testsuite/ld-arm/ifunc-12.dd
index 89a7530..cfae9a5 100644
--- a/ld/testsuite/ld-arm/ifunc-12.dd
+++ b/ld/testsuite/ld-arm/ifunc-12.dd
@@ -23,8 +23,8 @@ Disassembly of section \.text:
     a010:	46f7      	mov	pc, lr
 
 0000a012 <_start>:
-    a012:	f8df 4004 	ldr\.w	r4, \[pc, #4\]	; a018 <_start\+0x6>
-    a016:	4c01      	ldr	r4, \[pc, #4\]	; \(a01c <_start\+0xa>\)
+    a012:	f8df 4004 	ldr\.w	r4, \[pc, #4\]	@ a018 <_start\+0x6>
+    a016:	4c01      	ldr	r4, \[pc, #4\]	@ \(a01c <_start\+0xa>\)
 #------------------------------------------------------------------------------
 #------ .got offset for foo
 #------------------------------------------------------------------------------
@@ -33,8 +33,8 @@ Disassembly of section \.text:
 #------ PC-relative offset of .got entry for foo
 #------------------------------------------------------------------------------
     a01c:	00006ff0 	\.word	0x00006ff0
-    a020:	4c00      	ldr	r4, \[pc, #0\]	; \(a024 <_start\+0x12>\)
-    a022:	4c01      	ldr	r4, \[pc, #4\]	; \(a028 <_start\+0x16>\)
+    a020:	4c00      	ldr	r4, \[pc, #0\]	@ \(a024 <_start\+0x12>\)
+    a022:	4c01      	ldr	r4, \[pc, #4\]	@ \(a028 <_start\+0x16>\)
 #------------------------------------------------------------------------------
 #------ .got offset for f1
 #------------------------------------------------------------------------------
@@ -43,8 +43,8 @@ Disassembly of section \.text:
 #------ PC-relative offset of .got entry for f1
 #------------------------------------------------------------------------------
     a028:	00006fe8 	\.word	0x00006fe8
-    a02c:	4c00      	ldr	r4, \[pc, #0\]	; \(a030 <_start\+0x1e>\)
-    a02e:	4c01      	ldr	r4, \[pc, #4\]	; \(a034 <_start\+0x22>\)
+    a02c:	4c00      	ldr	r4, \[pc, #0\]	@ \(a030 <_start\+0x1e>\)
+    a02e:	4c01      	ldr	r4, \[pc, #4\]	@ \(a034 <_start\+0x22>\)
 #------------------------------------------------------------------------------
 #------ .got offset for f2
 #------------------------------------------------------------------------------
@@ -53,8 +53,8 @@ Disassembly of section \.text:
 #------ PC-relative offset of .got entry for f2
 #------------------------------------------------------------------------------
     a034:	00006ff0 	\.word	0x00006ff0
-    a038:	4c00      	ldr	r4, \[pc, #0\]	; \(a03c <_start\+0x2a>\)
-    a03a:	4c01      	ldr	r4, \[pc, #4\]	; \(a040 <_start\+0x2e>\)
+    a038:	4c00      	ldr	r4, \[pc, #0\]	@ \(a03c <_start\+0x2a>\)
+    a03a:	4c01      	ldr	r4, \[pc, #4\]	@ \(a040 <_start\+0x2e>\)
 #------------------------------------------------------------------------------
 #------ .got offset for f3
 #------------------------------------------------------------------------------
@@ -63,8 +63,8 @@ Disassembly of section \.text:
 #------ PC-relative offset of .got entry for f3
 #------------------------------------------------------------------------------
     a040:	00006fe0 	\.word	0x00006fe0
-    a044:	4c00      	ldr	r4, \[pc, #0\]	; \(a048 <_start\+0x36>\)
-    a046:	4c01      	ldr	r4, \[pc, #4\]	; \(a04c <_start\+0x3a>\)
+    a044:	4c00      	ldr	r4, \[pc, #0\]	@ \(a048 <_start\+0x36>\)
+    a046:	4c01      	ldr	r4, \[pc, #4\]	@ \(a04c <_start\+0x3a>\)
 #------------------------------------------------------------------------------
 #------ .got offset for f1t
 #------------------------------------------------------------------------------
@@ -73,8 +73,8 @@ Disassembly of section \.text:
 #------ PC-relative offset of .got entry for f1t
 #------------------------------------------------------------------------------
     a04c:	00006fc8 	\.word	0x00006fc8
-    a050:	4c00      	ldr	r4, \[pc, #0\]	; \(a054 <_start\+0x42>\)
-    a052:	4c01      	ldr	r4, \[pc, #4\]	; \(a058 <_start\+0x46>\)
+    a050:	4c00      	ldr	r4, \[pc, #0\]	@ \(a054 <_start\+0x42>\)
+    a052:	4c01      	ldr	r4, \[pc, #4\]	@ \(a058 <_start\+0x46>\)
 #------------------------------------------------------------------------------
 #------ .got offset for f2t
 #------------------------------------------------------------------------------
@@ -83,8 +83,8 @@ Disassembly of section \.text:
 #------ PC-relative offset of .got entry for f2t
 #------------------------------------------------------------------------------
     a058:	00006fc4 	\.word	0x00006fc4
-    a05c:	4c00      	ldr	r4, \[pc, #0\]	; \(a060 <_start\+0x4e>\)
-    a05e:	4c01      	ldr	r4, \[pc, #4\]	; \(a064 <_start\+0x52>\)
+    a05c:	4c00      	ldr	r4, \[pc, #0\]	@ \(a060 <_start\+0x4e>\)
+    a05e:	4c01      	ldr	r4, \[pc, #4\]	@ \(a064 <_start\+0x52>\)
 #------------------------------------------------------------------------------
 #------ .got offset for f3t
 #------------------------------------------------------------------------------